RE: [PATCH v2 4/6] hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index mode

2024-09-25 Thread Jamin Lin
Hi Andres, > Subject: Re: [PATCH v2 4/6] hw/gpio/aspeed: Fix clear incorrect interrupt > status > for GPIO index mode > > Hi Jamin, > > On Wed, 2024-09-25 at 11:34 +0800, Jamin Lin wrote: > > The interrupt status field is W1C, where a set bit on read indicates >

Re: [PATCH v2 4/6] hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index mode

2024-09-25 Thread Andrew Jeffery
Hi Jamin, On Wed, 2024-09-25 at 11:34 +0800, Jamin Lin wrote: > The interrupt status field is W1C, where a set bit on read indicates an > interrupt is pending. If the bit extracted from data is set it should > clear the corresponding bit in group_value. However, if the extracted > bit is clear the

[PATCH v2 4/6] hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index mode

2024-09-24 Thread Jamin Lin via
The interrupt status field is W1C, where a set bit on read indicates an interrupt is pending. If the bit extracted from data is set it should clear the corresponding bit in group_value. However, if the extracted bit is clear then the value of the corresponding bit in group_value should be unchanged