Re: [PATCH v2 4/6] migration: Avoid multiple parsing of uri in migration code flow

2023-02-09 Thread Het Gala
On 09/02/23 7:36 pm, Daniel P. Berrangé wrote: On Thu, Feb 09, 2023 at 07:24:48PM +0530, Het Gala wrote: On 09/02/23 5:39 pm, Daniel P. Berrangé wrote: On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote: In existing senario, 'migrate' QAPI argument - string uri, is encoded twice to ext

Re: [PATCH v2 4/6] migration: Avoid multiple parsing of uri in migration code flow

2023-02-09 Thread Daniel P . Berrangé
On Thu, Feb 09, 2023 at 07:24:48PM +0530, Het Gala wrote: > > On 09/02/23 5:39 pm, Daniel P. Berrangé wrote: > > On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote: > > > In existing senario, 'migrate' QAPI argument - string uri, is encoded > > > twice to extract migration parameters for str

Re: [PATCH v2 4/6] migration: Avoid multiple parsing of uri in migration code flow

2023-02-09 Thread Het Gala
On 09/02/23 5:39 pm, Daniel P. Berrangé wrote: On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote: In existing senario, 'migrate' QAPI argument - string uri, is encoded twice to extract migration parameters for stream connection. This is not a good representation of migration wire protoco

Re: [PATCH v2 4/6] migration: Avoid multiple parsing of uri in migration code flow

2023-02-09 Thread Het Gala
On 09/02/23 4:10 pm, Daniel P. Berrangé wrote: On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote: In existing senario, 'migrate' QAPI argument - string uri, is encoded twice to extract migration parameters for stream connection. This is not a good representation of migration wire protoc

Re: [PATCH v2 4/6] migration: Avoid multiple parsing of uri in migration code flow

2023-02-09 Thread Daniel P . Berrangé
On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote: > In existing senario, 'migrate' QAPI argument - string uri, is encoded > twice to extract migration parameters for stream connection. This is > not a good representation of migration wire protocol as it is a data > encoding scheme within a

Re: [PATCH v2 4/6] migration: Avoid multiple parsing of uri in migration code flow

2023-02-09 Thread Daniel P . Berrangé
On Wed, Feb 08, 2023 at 09:35:58AM +, Het Gala wrote: > In existing senario, 'migrate' QAPI argument - string uri, is encoded > twice to extract migration parameters for stream connection. This is > not a good representation of migration wire protocol as it is a data > encoding scheme within a

[PATCH v2 4/6] migration: Avoid multiple parsing of uri in migration code flow

2023-02-08 Thread Het Gala
In existing senario, 'migrate' QAPI argument - string uri, is encoded twice to extract migration parameters for stream connection. This is not a good representation of migration wire protocol as it is a data encoding scheme within a data encoding scheme. Qemu should be able to directly work with re