Re: [PATCH v2 4/8] qapi/misc: Move query-uuid command with block code

2020-03-16 Thread Philippe Mathieu-Daudé
On 3/16/20 2:09 PM, Igor Mammedov wrote: On Mon, 16 Mar 2020 01:03:44 +0100 Philippe Mathieu-Daudé wrote: here should be why Indeed. Daniel explained on IRC the GUID structure is "standardized by microsoft as a way to detect when a guest has certain operations applied" to a saved snapshot.

Re: [PATCH v2 4/8] qapi/misc: Move query-uuid command with block code

2020-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2020 01:03:44 +0100 Philippe Mathieu-Daudé wrote: here should be why PS: I don't see a reason to move it to block code at all if this command is moved then it should be machine code > Signed-off-by: Philippe Mathieu-Daudé > --- > qapi/block-core.json | 30 +

[PATCH v2 4/8] qapi/misc: Move query-uuid command with block code

2020-03-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/block-core.json | 30 ++ qapi/misc.json | 30 -- block/iscsi.c| 2 +- stubs/uuid.c | 2 +- 4 files changed, 32 insertions(+), 32 deletions(-) diff --git a/qapi/block-cor