Re: [PATCH v2 5/5] python/aqmp: add socket bind step to legacy.py

2022-01-20 Thread John Snow
On Thu, Jan 20, 2022, 4:13 AM Daniel P. Berrangé wrote: > On Wed, Jan 19, 2022 at 02:39:16PM -0500, John Snow wrote: > > The old QMP library would actually bind to the server address during > > __init__(). The new library delays this to the accept() call, because > > binding occurs inside of the

Re: [PATCH v2 5/5] python/aqmp: add socket bind step to legacy.py

2022-01-20 Thread Daniel P . Berrangé
On Wed, Jan 19, 2022 at 02:39:16PM -0500, John Snow wrote: > The old QMP library would actually bind to the server address during > __init__(). The new library delays this to the accept() call, because > binding occurs inside of the call to start_[unix_]server(), which is an > async method -- so it

[PATCH v2 5/5] python/aqmp: add socket bind step to legacy.py

2022-01-19 Thread John Snow
The old QMP library would actually bind to the server address during __init__(). The new library delays this to the accept() call, because binding occurs inside of the call to start_[unix_]server(), which is an async method -- so it cannot happen during __init__ anymore. Python 3.7+ adds the abili