Re: [PATCH v2 5/6] hw/i386/pc: Populate RTC attribute directly

2024-02-26 Thread Zhao Liu
On Sat, Feb 24, 2024 at 02:58:50PM +0100, Bernhard Beschow wrote: > Date: Sat, 24 Feb 2024 14:58:50 +0100 > From: Bernhard Beschow > Subject: [PATCH v2 5/6] hw/i386/pc: Populate RTC attribute directly > X-Mailer: git-send-email 2.44.0 > > Both the piix and the q35 machines intr

[PATCH v2 5/6] hw/i386/pc: Populate RTC attribute directly

2024-02-24 Thread Bernhard Beschow
Both the piix and the q35 machines introduce an rtc_state variable and defer the initialization of the X86MachineState::rtc attribute to pc_cmos_init(). Resolve this complication which makes pc_cmos_init() do what it says on the tin. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S.