Re: [PATCH v2 5/7] s390x/mmu: Use TARGET_PAGE_MASK in mmu_translate_pte()

2019-09-25 Thread Richard Henderson
On 9/25/19 5:52 AM, David Hildenbrand wrote: > While ASCE_ORIGIN is not wrong, it is certainly confusing. We want a > page frame address. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson

Re: [PATCH v2 5/7] s390x/mmu: Use TARGET_PAGE_MASK in mmu_translate_pte()

2019-09-25 Thread Thomas Huth
On 25/09/2019 14.52, David Hildenbrand wrote: > While ASCE_ORIGIN is not wrong, it is certainly confusing. We want a > page frame address. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x

[PATCH v2 5/7] s390x/mmu: Use TARGET_PAGE_MASK in mmu_translate_pte()

2019-09-25 Thread David Hildenbrand
While ASCE_ORIGIN is not wrong, it is certainly confusing. We want a page frame address. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index c9fde78614..20e9