Re: [PATCH v2 5/8] hw/arm/virt: Fix devicetree warnings about the GPIO node

2022-11-30 Thread Peter Maydell
On Tue, 29 Nov 2022 at 20:56, Rob Herring wrote: > > On Tue, Sep 27, 2022 at 6:25 AM Peter Maydell > wrote: > > > > On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker > > wrote: > > > > > > Since the pl061 device can be used as interrupt controller, its node > > > should contain "interrupt-co

Re: [PATCH v2 5/8] hw/arm/virt: Fix devicetree warnings about the GPIO node

2022-11-29 Thread Rob Herring
On Tue, Sep 27, 2022 at 6:25 AM Peter Maydell wrote: > > On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker > wrote: > > > > Since the pl061 device can be used as interrupt controller, its node > > should contain "interrupt-controller" and "#interrupt-cells" properties. > > It *can* be, but thi

Re: [PATCH v2 5/8] hw/arm/virt: Fix devicetree warnings about the GPIO node

2022-09-27 Thread Peter Maydell
On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker wrote: > > Since the pl061 device can be used as interrupt controller, its node > should contain "interrupt-controller" and "#interrupt-cells" properties. It *can* be, but this PL061 is *not* an interrupt controller. I don't see any reason why

[PATCH v2 5/8] hw/arm/virt: Fix devicetree warnings about the GPIO node

2022-09-27 Thread Jean-Philippe Brucker
Since the pl061 device can be used as interrupt controller, its node should contain "interrupt-controller" and "#interrupt-cells" properties. Fix the corresponding dt-validate warnings: pl061@903: 'interrupt-controller' is a required property From schema: linux/Documentation/devicetree/bin