Re: [PATCH v2 6/6] hw/i386/pc_sysfw: Alias rather than copy isa-bios region

2024-05-08 Thread Paolo Bonzini
On Tue, Apr 30, 2024 at 5:39 PM Philippe Mathieu-Daudé wrote: > I'm still not convinced we need a migration back compat for this... It's absolutely needed, memory_region_init_ram(isa_bios, NULL, "isa-bios", isa_bios_size, &error_fatal); will register a RAM region

Re: [PATCH v2 6/6] hw/i386/pc_sysfw: Alias rather than copy isa-bios region

2024-05-08 Thread Philippe Mathieu-Daudé
On 8/5/24 10:17, Bernhard Beschow wrote: Am 30. April 2024 15:39:21 UTC schrieb "Philippe Mathieu-Daudé" : On 30/4/24 17:06, Bernhard Beschow wrote: In the -bios case the "isa-bios" memory region is an alias to the BIOS mapped to the top of the 4G memory boundary. Do the same in the -pflash

Re: [PATCH v2 6/6] hw/i386/pc_sysfw: Alias rather than copy isa-bios region

2024-05-08 Thread Bernhard Beschow
Am 30. April 2024 15:39:21 UTC schrieb "Philippe Mathieu-Daudé" : >On 30/4/24 17:06, Bernhard Beschow wrote: >> In the -bios case the "isa-bios" memory region is an alias to the BIOS mapped >> to the top of the 4G memory boundary. Do the same in the -pflash case, but >> only >> for new machine

Re: [PATCH v2 6/6] hw/i386/pc_sysfw: Alias rather than copy isa-bios region

2024-04-30 Thread Philippe Mathieu-Daudé
On 30/4/24 17:06, Bernhard Beschow wrote: In the -bios case the "isa-bios" memory region is an alias to the BIOS mapped to the top of the 4G memory boundary. Do the same in the -pflash case, but only for new machine versions for migration compatibility. This establishes common behavior and makes

[PATCH v2 6/6] hw/i386/pc_sysfw: Alias rather than copy isa-bios region

2024-04-30 Thread Bernhard Beschow
In the -bios case the "isa-bios" memory region is an alias to the BIOS mapped to the top of the 4G memory boundary. Do the same in the -pflash case, but only for new machine versions for migration compatibility. This establishes common behavior and makes pflash commands work in the "isa-bios" regio