Re: [PATCH v2 6/7] migration/postcopy: Use uffd helpers

2024-09-30 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Sep 19, 2024 at 02:46:25PM +0100, d...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers > > rather than calling ioctl ourselves. > > > > They return -errno on error, and pr

Re: [PATCH v2 6/7] migration/postcopy: Use uffd helpers

2024-09-30 Thread Peter Xu
On Thu, Sep 19, 2024 at 02:46:25PM +0100, d...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers > rather than calling ioctl ourselves. > > They return -errno on error, and print an error_report themselves. > I think this actua

Re: [PATCH v2 6/7] migration/postcopy: Use uffd helpers

2024-09-19 Thread Peter Xu
On Thu, Sep 19, 2024 at 02:46:25PM +0100, d...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers > rather than calling ioctl ourselves. > > They return -errno on error, and print an error_report themselves. > I think this actua

[PATCH v2 6/7] migration/postcopy: Use uffd helpers

2024-09-19 Thread dave
From: "Dr. David Alan Gilbert" Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers rather than calling ioctl ourselves. They return -errno on error, and print an error_report themselves. I think this actually makes postcopy_place_page actually more consistent in it's callers. Signed-