Re: [PATCH v2 6/7] target/nios2: Remove assignment to env in handle_instruction

2021-06-28 Thread Richard Henderson
On 6/28/21 8:31 AM, Peter Maydell wrote: On Sun, 20 Jun 2021 at 23:15, Richard Henderson wrote: Direct assignments to env during translation do not work. As it happens, the only way we can get here is if env->pc is already set to dc->pc. More to the point, t_gen_helper_raise_exception() doe

Re: [PATCH v2 6/7] target/nios2: Remove assignment to env in handle_instruction

2021-06-28 Thread Peter Maydell
On Sun, 20 Jun 2021 at 23:15, Richard Henderson wrote: > > Direct assignments to env during translation do not work. > > As it happens, the only way we can get here is if env->pc > is already set to dc->pc. More to the point, t_gen_helper_raise_exception() does tcg_gen_movi_tl(dc->cpu_R[R_PC]

[PATCH v2 6/7] target/nios2: Remove assignment to env in handle_instruction

2021-06-20 Thread Richard Henderson
Direct assignments to env during translation do not work. As it happens, the only way we can get here is if env->pc is already set to dc->pc. We will trap on the first insn we execute anywhere on the page. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 3 ++- 1 file changed, 2