Re: [PATCH v2 6/7] util/fifo8: Expose fifo8_pop_buf()

2024-07-22 Thread Mark Cave-Ayland
On 22/07/2024 22:39, Philippe Mathieu-Daudé wrote: Hi Mark, On 22/7/24 23:26, Mark Cave-Ayland wrote: On 22/07/2024 17:07, Philippe Mathieu-Daudé wrote: Extract fifo8_pop_buf() from hw/scsi/esp.c and expose it as part of the API. This function takes care of non-contiguous (wrapped) FIFO buf

Re: [PATCH v2 6/7] util/fifo8: Expose fifo8_pop_buf()

2024-07-22 Thread Philippe Mathieu-Daudé
Hi Mark, On 22/7/24 23:26, Mark Cave-Ayland wrote: On 22/07/2024 17:07, Philippe Mathieu-Daudé wrote: Extract fifo8_pop_buf() from hw/scsi/esp.c and expose it as part of the API. This function takes care of non-contiguous (wrapped) FIFO buffer (which is an implementation detail). I wonder i

Re: [PATCH v2 6/7] util/fifo8: Expose fifo8_pop_buf()

2024-07-22 Thread Mark Cave-Ayland
On 22/07/2024 17:07, Philippe Mathieu-Daudé wrote: Extract fifo8_pop_buf() from hw/scsi/esp.c and expose it as part of the API. This function takes care of non-contiguous (wrapped) FIFO buffer (which is an implementation detail). I wonder if it is also worth updating the comment for fifo8_pop

Re: [PATCH v2 6/7] util/fifo8: Expose fifo8_pop_buf()

2024-07-22 Thread Pierrick Bouvier
On 7/22/24 09:07, Philippe Mathieu-Daudé wrote: Extract fifo8_pop_buf() from hw/scsi/esp.c and expose it as part of the API. This function takes care of non-contiguous (wrapped) FIFO buffer (which is an implementation detail). Suggested-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daud

[PATCH v2 6/7] util/fifo8: Expose fifo8_pop_buf()

2024-07-22 Thread Philippe Mathieu-Daudé
Extract fifo8_pop_buf() from hw/scsi/esp.c and expose it as part of the API. This function takes care of non-contiguous (wrapped) FIFO buffer (which is an implementation detail). Suggested-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/fifo8.h | 14 ++