Re: [PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD

2020-09-29 Thread Kamil Rytarowski
On 29.09.2020 10:58, Peter Maydell wrote: > On Mon, 28 Sep 2020 at 23:02, Kamil Rytarowski wrote: >> >> Personally, I prefer using the system headers. but if you want to use >> the GCC builtins, please go for it. > > I'd agree if the system header approach was cross-platform > or if this was a

Re: [PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD

2020-09-29 Thread Peter Maydell
On Mon, 28 Sep 2020 at 23:02, Kamil Rytarowski wrote: > > Personally, I prefer using the system headers. but if you want to use > the GCC builtins, please go for it. I'd agree if the system header approach was cross-platform or if this was a BSD-only program or if we were aiming for complete

Re: [PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD

2020-09-28 Thread Kamil Rytarowski
On 28.09.2020 15:19, Philippe Mathieu-Daudé wrote: > Since commit efc6c070aca ("configure: Add a test for the minimum > compiler version") the minimum compiler version required for GCC > is 4.8, which supports __builtin_bswap(). > Remove the NetBSD specific ifdef'ry. > > This reverts commit

[PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD

2020-09-28 Thread Philippe Mathieu-Daudé
Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which supports __builtin_bswap(). Remove the NetBSD specific ifdef'ry. This reverts commit 1360677cfe3ca8f945fa1de77823df21a77e4500 ("makes NetBSD use the