Re: [PATCH v2 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail

2021-09-25 Thread Philippe Mathieu-Daudé
On 9/22/21 06:56, Warner Losh wrote: Similar to the equivalent linux-user change 86abac06c14. All error conditions that target_mprotect checks are also checked by target_mmap. EACCESS cannot happen because we are just removing PROT_WRITE. ENOMEM should not happen because we are modifying a whole

Re: [PATCH v2 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail

2021-09-24 Thread Richard Henderson
On 9/21/21 9:56 PM, Warner Losh wrote: Similar to the equivalent linux-user change 86abac06c14. All error conditions that target_mprotect checks are also checked by target_mmap. EACCESS cannot happen because we are just removing PROT_WRITE. ENOMEM should not happen because we are modifying a who

[PATCH v2 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail

2021-09-21 Thread Warner Losh
Similar to the equivalent linux-user change 86abac06c14. All error conditions that target_mprotect checks are also checked by target_mmap. EACCESS cannot happen because we are just removing PROT_WRITE. ENOMEM should not happen because we are modifying a whole VMA (and we have bigger problems anywa