Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-26 Thread David Hildenbrand
On 24.02.20 15:16, Murilo Opsfelder Araújo wrote: > On Monday, February 24, 2020 7:57:03 AM -03 David Hildenbrand wrote: >> On 24.02.20 11:50, David Hildenbrand wrote: >>> On 19.02.20 23:46, Peter Xu wrote: On Wed, Feb 12, 2020 at 02:42:46PM +0100, David Hildenbrand wrote: > Factor it out

Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-24 Thread David Hildenbrand
On 24.02.20 18:36, Peter Xu wrote: > On Mon, Feb 24, 2020 at 11:57:03AM +0100, David Hildenbrand wrote: >> On 24.02.20 11:50, David Hildenbrand wrote: >>> On 19.02.20 23:46, Peter Xu wrote: On Wed, Feb 12, 2020 at 02:42:46PM +0100, David Hildenbrand wrote: > Factor it out and add a comment

Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-24 Thread Peter Xu
On Mon, Feb 24, 2020 at 11:57:03AM +0100, David Hildenbrand wrote: > On 24.02.20 11:50, David Hildenbrand wrote: > > On 19.02.20 23:46, Peter Xu wrote: > >> On Wed, Feb 12, 2020 at 02:42:46PM +0100, David Hildenbrand wrote: > >>> Factor it out and add a comment. > >>> > >>> Reviewed-by: Igor Kotras

Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-24 Thread David Hildenbrand
On 24.02.20 15:25, Murilo Opsfelder Araújo wrote: > On Monday, February 24, 2020 11:16:16 AM -03 Murilo Opsfelder Araújo wrote: >> On Monday, February 24, 2020 7:57:03 AM -03 David Hildenbrand wrote: >>> On 24.02.20 11:50, David Hildenbrand wrote: On 19.02.20 23:46, Peter Xu wrote: > On We

Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-24 Thread Murilo Opsfelder Araújo
On Monday, February 24, 2020 11:16:16 AM -03 Murilo Opsfelder Araújo wrote: > On Monday, February 24, 2020 7:57:03 AM -03 David Hildenbrand wrote: > > On 24.02.20 11:50, David Hildenbrand wrote: > > > On 19.02.20 23:46, Peter Xu wrote: > > >> On Wed, Feb 12, 2020 at 02:42:46PM +0100, David Hildenbr

Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-24 Thread Murilo Opsfelder Araújo
On Monday, February 24, 2020 7:57:03 AM -03 David Hildenbrand wrote: > On 24.02.20 11:50, David Hildenbrand wrote: > > On 19.02.20 23:46, Peter Xu wrote: > >> On Wed, Feb 12, 2020 at 02:42:46PM +0100, David Hildenbrand wrote: > >>> Factor it out and add a comment. > >>> > >>> Reviewed-by: Igor Kotr

Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-24 Thread David Hildenbrand
On 24.02.20 11:50, David Hildenbrand wrote: > On 19.02.20 23:46, Peter Xu wrote: >> On Wed, Feb 12, 2020 at 02:42:46PM +0100, David Hildenbrand wrote: >>> Factor it out and add a comment. >>> >>> Reviewed-by: Igor Kotrasinski >>> Acked-by: Murilo Opsfelder Araujo >>> Reviewed-by: Richard Henderso

Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-24 Thread David Hildenbrand
On 19.02.20 23:46, Peter Xu wrote: > On Wed, Feb 12, 2020 at 02:42:46PM +0100, David Hildenbrand wrote: >> Factor it out and add a comment. >> >> Reviewed-by: Igor Kotrasinski >> Acked-by: Murilo Opsfelder Araujo >> Reviewed-by: Richard Henderson >> Cc: "Michael S. Tsirkin" >> Cc: Murilo Opsfel

Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-19 Thread Peter Xu
On Wed, Feb 12, 2020 at 02:42:46PM +0100, David Hildenbrand wrote: > Factor it out and add a comment. > > Reviewed-by: Igor Kotrasinski > Acked-by: Murilo Opsfelder Araujo > Reviewed-by: Richard Henderson > Cc: "Michael S. Tsirkin" > Cc: Murilo Opsfelder Araujo > Cc: Greg Kurz > Cc: Eduardo

[PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-12 Thread David Hildenbrand
Factor it out and add a comment. Reviewed-by: Igor Kotrasinski Acked-by: Murilo Opsfelder Araujo Reviewed-by: Richard Henderson Cc: "Michael S. Tsirkin" Cc: Murilo Opsfelder Araujo Cc: Greg Kurz Cc: Eduardo Habkost Cc: "Dr. David Alan Gilbert" Cc: Igor Mammedov Signed-off-by: David Hilden