Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-05-19 Thread Roman Kagan
On Tue, May 19, 2020 at 04:08:26PM +0200, Kevin Wolf wrote: > Am 29.04.2020 um 11:18 hat Roman Kagan geschrieben: > > Devices (virtio-blk, scsi, etc.) and the block layer are happy to use > > 32-bit for logical_block_size, physical_block_size, and min_io_size. > > However, the properties in

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-05-19 Thread Kevin Wolf
Am 29.04.2020 um 11:18 hat Roman Kagan geschrieben: > Devices (virtio-blk, scsi, etc.) and the block layer are happy to use > 32-bit for logical_block_size, physical_block_size, and min_io_size. > However, the properties in BlockConf are defined as uint16_t limiting > the values to 32768. > >

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-05-19 Thread Roman Kagan
On Wed, Apr 29, 2020 at 12:18:13PM +0300, Roman Kagan wrote: > Devices (virtio-blk, scsi, etc.) and the block layer are happy to use > 32-bit for logical_block_size, physical_block_size, and min_io_size. > However, the properties in BlockConf are defined as uint16_t limiting > the values to 32768.

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-30 Thread Philippe Mathieu-Daudé
On 4/30/20 11:25 AM, Roman Kagan wrote: On Wed, Apr 29, 2020 at 02:59:31PM +0200, Philippe Mathieu-Daudé wrote: On 4/29/20 2:19 PM, Roman Kagan wrote: On Wed, Apr 29, 2020 at 11:41:04AM +0200, Philippe Mathieu-Daudé wrote: Cc'ing virtio-blk and scsi maintainers. On 4/29/20 11:18 AM, Roman

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-30 Thread Roman Kagan
On Wed, Apr 29, 2020 at 02:59:31PM +0200, Philippe Mathieu-Daudé wrote: > On 4/29/20 2:19 PM, Roman Kagan wrote: > > On Wed, Apr 29, 2020 at 11:41:04AM +0200, Philippe Mathieu-Daudé wrote: > > > Cc'ing virtio-blk and scsi maintainers. > > > > > > On 4/29/20 11:18 AM, Roman Kagan wrote: > > > >

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-29 Thread Philippe Mathieu-Daudé
On 4/29/20 2:19 PM, Roman Kagan wrote: On Wed, Apr 29, 2020 at 11:41:04AM +0200, Philippe Mathieu-Daudé wrote: Cc'ing virtio-blk and scsi maintainers. On 4/29/20 11:18 AM, Roman Kagan wrote: Devices (virtio-blk, scsi, etc.) and the block layer are happy to use 32-bit for logical_block_size,

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-29 Thread Roman Kagan
On Wed, Apr 29, 2020 at 11:41:04AM +0200, Philippe Mathieu-Daudé wrote: > Cc'ing virtio-blk and scsi maintainers. > > On 4/29/20 11:18 AM, Roman Kagan wrote: > > Devices (virtio-blk, scsi, etc.) and the block layer are happy to use > > 32-bit for logical_block_size, physical_block_size, and

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-29 Thread Philippe Mathieu-Daudé
Cc'ing virtio-blk and scsi maintainers. On 4/29/20 11:18 AM, Roman Kagan wrote: Devices (virtio-blk, scsi, etc.) and the block layer are happy to use 32-bit for logical_block_size, physical_block_size, and min_io_size. However, the properties in BlockConf are defined as uint16_t limiting the

[PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-29 Thread Roman Kagan
Devices (virtio-blk, scsi, etc.) and the block layer are happy to use 32-bit for logical_block_size, physical_block_size, and min_io_size. However, the properties in BlockConf are defined as uint16_t limiting the values to 32768. This appears unnecessary tight, and we've seen bigger block sizes