RE: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Xingtao Yao (Fujitsu)
: Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning > > On 26/3/24 11:33, Peter Maydell wrote: > > On Tue, 26 Mar 2024 at 09:54, Philippe Mathieu-Daudé > wrote: > >> > >> On 26/3/24 04:33, Pierrick Bouvier wrote: > >>> On 3/26/24 05:52, Yao Xin

Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Pierrick Bouvier
On 3/26/24 13:54, Philippe Mathieu-Daudé wrote: I will post a small PR later today, so until Peter has something else planned, I can take it, since the patch LGTM now. Thanks Philippe :)

Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Philippe Mathieu-Daudé
On 26/3/24 11:33, Peter Maydell wrote: On Tue, 26 Mar 2024 at 09:54, Philippe Mathieu-Daudé wrote: On 26/3/24 04:33, Pierrick Bouvier wrote: On 3/26/24 05:52, Yao Xingtao wrote: 1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70. Use g_pattern_spec_match_string()

Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Peter Maydell
On Tue, 26 Mar 2024 at 09:54, Philippe Mathieu-Daudé wrote: > > On 26/3/24 04:33, Pierrick Bouvier wrote: > > On 3/26/24 05:52, Yao Xingtao wrote: > >> 1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70. > >> Use g_pattern_spec_match_string() instead to avoid this

Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Philippe Mathieu-Daudé
On 26/3/24 04:33, Pierrick Bouvier wrote: On 3/26/24 05:52, Yao Xingtao wrote: 1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70.     Use g_pattern_spec_match_string() instead to avoid this problem. 2. The type of second parameter in g_ptr_array_add() is     'gpointer'

Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-25 Thread Pierrick Bouvier
On 3/26/24 05:52, Yao Xingtao wrote: 1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70. Use g_pattern_spec_match_string() instead to avoid this problem. 2. The type of second parameter in g_ptr_array_add() is 'gpointer' {aka 'void *'}, but the type of reg->name is

[PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-25 Thread Yao Xingtao via
1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70. Use g_pattern_spec_match_string() instead to avoid this problem. 2. The type of second parameter in g_ptr_array_add() is 'gpointer' {aka 'void *'}, but the type of reg->name is 'const char*'. Cast the type of