Re: [PATCH v3] hw/ppc: Implement -dtb support for PowerNV

2024-08-19 Thread Aditya Gupta
Hello Nick, On 16/08/24 07:50, Nicholas Piggin wrote: <...snip...> One little nit is MachineState.fdt vs PnvMachineState.fdt which is now confusing. I would call the new PnvMachineState member something like fdt_from_dtb, or fdt_override? I agree. this is confusing. machine->fdt could be used

Re: [PATCH v3] hw/ppc: Implement -dtb support for PowerNV

2024-08-19 Thread Aditya Gupta
Hi Cedric, On 15/08/24 23:22, Cédric Le Goater wrote: I don't think this is a bug fix. is it ? AFAIUI, it is a debug feature for skiboot. It's QEMU 9.2 material. Thanks for answering Nick's question, I did not check my mails. Yes, it can be considered a debug feature. One little nit is Ma

Re: [PATCH v3] hw/ppc: Implement -dtb support for PowerNV

2024-08-15 Thread Nicholas Piggin
On Fri Aug 16, 2024 at 3:52 AM AEST, Cédric Le Goater wrote: > On 8/15/24 09:31, Nicholas Piggin wrote: > > On Tue Aug 13, 2024 at 11:45 PM AEST, Aditya Gupta wrote: > >> Currently any device tree passed with -dtb option in QEMU, was ignored > >> by the PowerNV code. > >> > >> Read and pass the pas

Re: [PATCH v3] hw/ppc: Implement -dtb support for PowerNV

2024-08-15 Thread Cédric Le Goater
On 8/15/24 09:31, Nicholas Piggin wrote: On Tue Aug 13, 2024 at 11:45 PM AEST, Aditya Gupta wrote: Currently any device tree passed with -dtb option in QEMU, was ignored by the PowerNV code. Read and pass the passed -dtb to the kernel, thus enabling easier debugging with custom DTBs. The exist

Re: [PATCH v3] hw/ppc: Implement -dtb support for PowerNV

2024-08-15 Thread Nicholas Piggin
On Tue Aug 13, 2024 at 11:45 PM AEST, Aditya Gupta wrote: > Currently any device tree passed with -dtb option in QEMU, was ignored > by the PowerNV code. > > Read and pass the passed -dtb to the kernel, thus enabling easier > debugging with custom DTBs. > > The existing behaviour when -dtb is 'not'

[PATCH v3] hw/ppc: Implement -dtb support for PowerNV

2024-08-13 Thread Aditya Gupta
Currently any device tree passed with -dtb option in QEMU, was ignored by the PowerNV code. Read and pass the passed -dtb to the kernel, thus enabling easier debugging with custom DTBs. The existing behaviour when -dtb is 'not' passed, is preserved as-is. But when a '-dtb' is passed, it complete