Het Gala writes:
> On 29/11/23 6:21 pm, Markus Armbruster wrote:
>> I'ld like to suggest a clearer subject:
>>
>>migration: Plug memory leak with migration URIs
> Ack. Will update the commit message
>> Het Gala writes:
>>
>>> 'channel' in qmp_migrate() and qmp_migrate_incoming() is not
>>>
On 29/11/23 6:21 pm, Markus Armbruster wrote:
I'ld like to suggest a clearer subject:
migration: Plug memory leak with migration URIs
Ack. Will update the commit message
Het Gala writes:
'channel' in qmp_migrate() and qmp_migrate_incoming() is not
auto-freed. migrate_uri_parse()
Markus Armbruster writes:
> I'ld like to suggest a clearer subject:
>
> migration: Plug memory leak with migration URIs
>
> Het Gala writes:
>
>> 'channel' in qmp_migrate() and qmp_migrate_incoming() is not
>> auto-freed. migrate_uri_parse() allocates memory to 'channel' if
>
> Not sure we
I'ld like to suggest a clearer subject:
migration: Plug memory leak with migration URIs
Het Gala writes:
> 'channel' in qmp_migrate() and qmp_migrate_incoming() is not
> auto-freed. migrate_uri_parse() allocates memory to 'channel' if
Not sure we need the first sentence. QMP commands never
'channel' in qmp_migrate() and qmp_migrate_incoming() is not
auto-freed. migrate_uri_parse() allocates memory to 'channel' if
the user opts for old syntax - uri, which is leaked because there
is no code for freeing 'channel'.
So, free channel to avoid memory leak in case where 'channels'
is empty
