Re: [PATCH v3] migration: free 'saddr' since be no longer used

2023-11-30 Thread Het Gala
On 29/11/23 8:17 pm, Peter Xu wrote: On Wed, Nov 29, 2023 at 10:09:12AM +0800, Zongmin Zhou wrote: Ping? Has this been forgotten? Juan, Would you send a pull to include this? Thanks! Peter, Juan - Could you also pull a similar patch related to memory leak together, it has been tested and

Re: [PATCH v3] migration: free 'saddr' since be no longer used

2023-11-29 Thread Peter Xu
On Wed, Nov 29, 2023 at 10:09:12AM +0800, Zongmin Zhou wrote: > Ping? Has this been forgotten? Juan, Would you send a pull to include this? Thanks! -- Peter Xu

Re: [PATCH v3] migration: free 'saddr' since be no longer used

2023-11-28 Thread Zongmin Zhou
Ping? Has this been forgotten? Best regards! On 2023/11/20 22:01, Peter Xu wrote: On Mon, Nov 20, 2023 at 11:14:28AM +0800, Zongmin Zhou wrote: Since socket_parse() will allocate memory for 'saddr',and its value will pass to 'addr' that allocated by migrate_uri_parse(), then 'saddr' will no

Re: [PATCH v3] migration: free 'saddr' since be no longer used

2023-11-20 Thread Peter Xu
On Mon, Nov 20, 2023 at 11:14:28AM +0800, Zongmin Zhou wrote: > Since socket_parse() will allocate memory for 'saddr',and its value > will pass to 'addr' that allocated by migrate_uri_parse(), > then 'saddr' will no longer used,need to free. > But due to 'saddr->u' is shallow copying the contents

Re: [PATCH v3] migration: free 'saddr' since be no longer used

2023-11-20 Thread Daniel P . Berrangé
On Mon, Nov 20, 2023 at 11:14:28AM +0800, Zongmin Zhou wrote: > Since socket_parse() will allocate memory for 'saddr',and its value > will pass to 'addr' that allocated by migrate_uri_parse(), > then 'saddr' will no longer used,need to free. > But due to 'saddr->u' is shallow copying the contents

[PATCH v3] migration: free 'saddr' since be no longer used

2023-11-19 Thread Zongmin Zhou
Since socket_parse() will allocate memory for 'saddr',and its value will pass to 'addr' that allocated by migrate_uri_parse(), then 'saddr' will no longer used,need to free. But due to 'saddr->u' is shallow copying the contents of the union, the members of this union containing allocated