Re: [PATCH v3] target/i386: Change wrong XFRM value

2023-04-09 Thread Yang Zhong
On Sun, Apr 09, 2023 at 04:40:50PM +0300, Michael Tokarev wrote: > 06.04.2023 09:40, Yang Zhong wrote: > > The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with > > FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):{ECX,EDX}, which made > > SGX enclave only supported SSE and x87

Re: [PATCH v3] target/i386: Change wrong XFRM value

2023-04-09 Thread Michael Tokarev
06.04.2023 09:40, Yang Zhong wrote: The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):{ECX,EDX}, which made SGX enclave only supported SSE and x87 feature(xfrm=0x3). Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based

Re: [PATCH v3] target/i386: Change wrong XFRM value

2023-04-07 Thread Yang Zhong
On Thu, Apr 06, 2023 at 02:05:06PM +0200, Paolo Bonzini wrote: > Queued, thanks. > Paolo, thanks! Yang > Paolo > >

Re: [PATCH v3] target/i386: Change wrong XFRM value

2023-04-06 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH v3] target/i386: Change wrong XFRM value

2023-04-06 Thread Huang, Kai
On Thu, 2023-04-06 at 02:40 -0400, Yang Zhong wrote: > The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with > FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):{ECX,EDX}, which made > SGX enclave only supported SSE and x87 feature(xfrm=0x3). I don't particularly like the sentence's second

[PATCH v3] target/i386: Change wrong XFRM value

2023-04-06 Thread Yang Zhong
The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):{ECX,EDX}, which made SGX enclave only supported SSE and x87 feature(xfrm=0x3). Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features") Signed-off-by: Yang Zhong