[PATCH v3] tests/qtest: add qtests for npcm7xx sdhci

2022-02-08 Thread Patrick Venture
From: Shengtan Mao Reviewed-by: Hao Wu Reviewed-by: Chris Rauer Signed-off-by: Shengtan Mao Signed-off-by: Patrick Venture --- v3: * fixup compilation from missing macro value v2: * update copyright year * check result of open * use g_free instead of free * move declarations to the top

Re: [PATCH v3] tests/qtest: add qtests for npcm7xx sdhci

2022-02-16 Thread Peter Maydell
On Tue, 8 Feb 2022 at 18:18, Patrick Venture wrote: > > From: Shengtan Mao > > Reviewed-by: Hao Wu > Reviewed-by: Chris Rauer > Signed-off-by: Shengtan Mao > Signed-off-by: Patrick Venture > --- Applied to target-arm.next, thanks. -- PMM

Re: [PATCH v3] tests/qtest: add qtests for npcm7xx sdhci

2022-02-21 Thread Peter Maydell
On Wed, 16 Feb 2022 at 17:30, Peter Maydell wrote: > > On Tue, 8 Feb 2022 at 18:18, Patrick Venture wrote: > > > > From: Shengtan Mao > > > > Reviewed-by: Hao Wu > > Reviewed-by: Chris Rauer > > Signed-off-by: Shengtan Mao > > Signed-off-by: Patrick Venture > > --- > > > > Applied to target-

Re: [PATCH v3] tests/qtest: add qtests for npcm7xx sdhci

2022-02-22 Thread Patrick Venture
On Mon, Feb 21, 2022 at 5:30 AM Peter Maydell wrote: > On Wed, 16 Feb 2022 at 17:30, Peter Maydell > wrote: > > > > On Tue, 8 Feb 2022 at 18:18, Patrick Venture wrote: > > > > > > From: Shengtan Mao > > > > > > Reviewed-by: Hao Wu > > > Reviewed-by: Chris Rauer > > > Signed-off-by: Shengtan

Re: [PATCH v3] tests/qtest: add qtests for npcm7xx sdhci

2022-02-24 Thread Hao Wu
The problem is probably because we read it in using "strcmp". strcmp compares two strings that end with "\0". But one of the string is read in using read() so it didn't read in the ending '\0' character. We should use strncmp to compare the two strings. It probably avoids the issue. On Tue, Feb 2