Re: [PATCH v3] virtio-net: prevent offloads reset on migration

2019-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2019 at 04:58:09PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, Oct 10, 2019 at 02:11:15PM +0200, Mikhail Sennikovsky wrote: > > > Currently offloads disabled by guest via the > > > VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET > > > command

Re: [PATCH v3] virtio-net: prevent offloads reset on migration

2019-10-10 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Oct 10, 2019 at 02:11:15PM +0200, Mikhail Sennikovsky wrote: > > Currently offloads disabled by guest via the > > VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET > > command are not preserved on VM migration. > > Instead all offloads reported by guest fea

Re: [PATCH v3] virtio-net: prevent offloads reset on migration

2019-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2019 at 02:11:15PM +0200, Mikhail Sennikovsky wrote: > Currently offloads disabled by guest via the > VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET > command are not preserved on VM migration. > Instead all offloads reported by guest features (via > VIRTIO_PCI_GUEST_FEATURES) > get enabled.

Re: [PATCH v3] virtio-net: prevent offloads reset on migration

2019-10-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1570709475-32073-2-git-send-email-mikhail.sennikovs...@cloud.ionos.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally

Re: [PATCH v3] virtio-net: prevent offloads reset on migration

2019-10-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1570709475-32073-2-git-send-email-mikhail.sennikovs...@cloud.ionos.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locall

[PATCH v3] virtio-net: prevent offloads reset on migration

2019-10-10 Thread Mikhail Sennikovsky
Currently offloads disabled by guest via the VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET command are not preserved on VM migration. Instead all offloads reported by guest features (via VIRTIO_PCI_GUEST_FEATURES) get enabled. What happens is: first the VirtIONet::curr_guest_offloads gets restored and offload

[PATCH v3] virtio-net: prevent offloads reset on migration

2019-10-10 Thread Mikhail Sennikovsky
Hi all, This is the third version of the patch, implementing the approach based on checking the VM runstate proposed by Jason Wang. Regards, Mikhail Mikhail Sennikovsky (1): virtio-net: prevent offloads reset on migration hw/net/virtio-net.c | 9 - 1 file changed, 8 insertions(+), 1