Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-04-15 Thread Daniel P . Berrangé
On Mon, Apr 12, 2021 at 03:07:59PM +0200, Gerd Hoffmann wrote: > On Fri, Apr 09, 2021 at 02:17:13PM +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 09, 2021 at 03:12:45PM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > eg a trace point "dma_map_wait" gets mapped to probes in many > > > > .s

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-04-12 Thread Gerd Hoffmann
On Fri, Apr 09, 2021 at 02:17:13PM +0100, Daniel P. Berrangé wrote: > On Fri, Apr 09, 2021 at 03:12:45PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > eg a trace point "dma_map_wait" gets mapped to probes in many > > > .stp files, once per target, because we need to match based on > > > the exec

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-04-09 Thread Daniel P . Berrangé
On Fri, Apr 09, 2021 at 03:12:45PM +0200, Gerd Hoffmann wrote: > Hi, > > > eg a trace point "dma_map_wait" gets mapped to probes in many > > .stp files, once per target, because we need to match based on > > the executable path: > > > > probe qemu.system.x86_64.dma_map_wait = > > process("/u

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-04-09 Thread Gerd Hoffmann
Hi, > eg a trace point "dma_map_wait" gets mapped to probes in many > .stp files, once per target, because we need to match based on > the executable path: > > probe qemu.system.x86_64.dma_map_wait = > process("/usr/libexec/qemu-system-x86_64").mark("dma_map_wait") So, that changes with mod

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-04-09 Thread Gerd Hoffmann
Hi, > > semantic error: unresolved function pid: identifier 'pid' at > > /home/kraxel/qemu-install/share/systemtap/tapset/qemu-system-x86_64-log.stp:5451:41 > > source: printf("%d@%d qxl_soft_reset %d\n", pid(), > > gettimeofday_ns(), qid) > Hmm, strange, makes me think we have a

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-31 Thread Gerd Hoffmann
Hi, > > Well, "make install" with --prefix=$HOME/qemu-install fixed that for the > > time > > being. > > > > Now I have this: > > > > kraxel@sirius ~/qemu-install/bin# sudo ./qemu-trace-stap -v run > > ./qemu-system-x86_64 "qxl_soft_reset" > > Using tapset dir '/home/kraxel/qemu-install/shar

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-29 Thread Stefan Hajnoczi
On Mon, Mar 22, 2021 at 11:46:55AM +, Daniel P. Berrangé wrote: > On Mon, Mar 22, 2021 at 11:36:39AM +, Stefan Hajnoczi wrote: > > On Mon, Feb 22, 2021 at 04:13:32PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > TODO: > > > > > Enabling modular tracepoints via -trace cmd line doe

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-29 Thread Daniel P . Berrangé
On Mon, Mar 29, 2021 at 11:48:18AM +0200, Gerd Hoffmann wrote: > On Mon, Mar 29, 2021 at 10:23:42AM +0100, Daniel P. Berrangé wrote: > > On Fri, Mar 26, 2021 at 01:47:00PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > eg a trace point "dma_map_wait" gets mapped to probes in many > > > > .s

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-29 Thread Gerd Hoffmann
On Mon, Mar 29, 2021 at 10:23:42AM +0100, Daniel P. Berrangé wrote: > On Fri, Mar 26, 2021 at 01:47:00PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > eg a trace point "dma_map_wait" gets mapped to probes in many > > > .stp files, once per target, because we need to match based on > > > the exec

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-29 Thread Daniel P . Berrangé
On Fri, Mar 26, 2021 at 01:47:00PM +0100, Gerd Hoffmann wrote: > Hi, > > > eg a trace point "dma_map_wait" gets mapped to probes in many > > .stp files, once per target, because we need to match based on > > the executable path: > > > > probe qemu.system.x86_64.dma_map_wait = > > process("/u

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-26 Thread Gerd Hoffmann
Hi, > eg a trace point "dma_map_wait" gets mapped to probes in many > .stp files, once per target, because we need to match based on > the executable path: > > probe qemu.system.x86_64.dma_map_wait = > process("/usr/libexec/qemu-system-x86_64").mark("dma_map_wait") > probe qemu.system.x86_

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-22 Thread Daniel P . Berrangé
On Mon, Feb 22, 2021 at 04:13:32PM +0100, Gerd Hoffmann wrote: > Hi, > > > > TODO: > > > Enabling modular tracepoints via -trace cmd line doesn't work yet. > > > Guess we need to store the list somewhere for later re-processing. > > > Error handling is tricky, specifically the "tracepoint doesn'

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-22 Thread Daniel P . Berrangé
On Mon, Mar 22, 2021 at 11:36:39AM +, Stefan Hajnoczi wrote: > On Mon, Feb 22, 2021 at 04:13:32PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > TODO: > > > > Enabling modular tracepoints via -trace cmd line doesn't work yet. > > > > Guess we need to store the list somewhere for later re-pr

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-22 Thread Stefan Hajnoczi
On Mon, Feb 22, 2021 at 04:13:32PM +0100, Gerd Hoffmann wrote: > Hi, > > > > TODO: > > > Enabling modular tracepoints via -trace cmd line doesn't work yet. > > > Guess we need to store the list somewhere for later re-processing. > > > Error handling is tricky, specifically the "tracepoint doesn'

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-02-22 Thread Gerd Hoffmann
Hi, > > TODO: > > Enabling modular tracepoints via -trace cmd line doesn't work yet. > > Guess we need to store the list somewhere for later re-processing. > > Error handling is tricky, specifically the "tracepoint doesn't exist" > > error. Suggestions / ideas are welcome. > > Two ideas: > >

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-02-03 Thread Stefan Hajnoczi
On Thu, Jan 21, 2021 at 01:50:20PM +0100, Gerd Hoffmann wrote: > First version that actually works. Only qxl covered for this RfC, > other modules will follow once the basics are hashed out. > > v3: > - handle initialization of modular tracepoints. Cool, this looks promising! > TODO: > Enablin

[PATCH v3 0/8] [RfC] fix tracing for modules

2021-01-21 Thread Gerd Hoffmann
First version that actually works. Only qxl covered for this RfC, other modules will follow once the basics are hashed out. v3: - handle initialization of modular tracepoints. TODO: Enabling modular tracepoints via -trace cmd line doesn't work yet. Guess we need to store the list somewhere for