Re: [PATCH v3 0/8] PMBus fixes and new functions

2023-10-24 Thread Philippe Mathieu-Daudé
On 24/10/23 18:07, Titus Rwantare wrote: On Tue, 24 Oct 2023 at 04:50, Philippe Mathieu-Daudé wrote: On 24/10/23 12:06, Alex Bennée wrote: A pull request is really just a GPG signed tag that you push to a repo. You can use the existing git tooling to create the cover letter for it. I've

Re: [PATCH v3 0/8] PMBus fixes and new functions

2023-10-24 Thread Titus Rwantare
On Tue, 24 Oct 2023 at 04:50, Philippe Mathieu-Daudé wrote: > > On 24/10/23 12:06, Alex Bennée wrote: > > > A pull request is really just a GPG signed tag that you push to a repo. > > You can use the existing git tooling to create the cover letter for it. > > > > I've included my exact steps at

Re: [PATCH v3 0/8] PMBus fixes and new functions

2023-10-24 Thread Philippe Mathieu-Daudé
On 24/10/23 12:06, Alex Bennée wrote: A pull request is really just a GPG signed tag that you push to a repo. You can use the existing git tooling to create the cover letter for it. I've included my exact steps at the end of the email but really it comes down to: git tag --sign your-pr-tag

Re: [PATCH v3 0/8] PMBus fixes and new functions

2023-10-24 Thread Alex Bennée
Titus Rwantare writes: > On Mon, 23 Oct 2023 at 12:16, Alex Bennée wrote: > >> You seem to have missed a number of tags from previous postings: >> >> >> https://qemu.readthedocs.io/en/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review >> >> (although I

Re: [PATCH v3 0/8] PMBus fixes and new functions

2023-10-23 Thread Titus Rwantare
On Mon, 23 Oct 2023 at 12:16, Alex Bennée wrote: > You seem to have missed a number of tags from previous postings: > > > https://qemu.readthedocs.io/en/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review > > (although I notice we only mention Reviewed-by in the

Re: [PATCH v3 0/8] PMBus fixes and new functions

2023-10-23 Thread Alex Bennée
Titus Rwantare writes: > This patch series contains fixes and improvements to PMBus support in QEMU. > > The following has been added: >- Support for block receive >- Support for devices with fans >- Support for the VCAP register for devices with onboard energy storage >- A

[PATCH v3 0/8] PMBus fixes and new functions

2023-10-23 Thread Titus Rwantare
This patch series contains fixes and improvements to PMBus support in QEMU. The following has been added: - Support for block receive - Support for devices with fans - Support for the VCAP register for devices with onboard energy storage - A bitfield struct for the vout mode register,