Re: [PATCH v3 0/9] Generalize memory encryption models

2020-07-01 Thread Halil Pasic
On Fri, 26 Jun 2020 14:49:37 +0200 Janosch Frank wrote: > On 6/26/20 12:58 PM, Daniel P. Berrangé wrote: > > On Fri, Jun 26, 2020 at 11:29:03AM +0100, Dr. David Alan Gilbert wrote: > >> * Janosch Frank (fran...@linux.ibm.com) wrote: > >>> On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: > On

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Janosch Frank
On 6/26/20 12:58 PM, Daniel P. Berrangé wrote: > On Fri, Jun 26, 2020 at 11:29:03AM +0100, Dr. David Alan Gilbert wrote: >> * Janosch Frank (fran...@linux.ibm.com) wrote: >>> On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote: >

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Daniel P . Berrangé
On Fri, Jun 26, 2020 at 11:29:03AM +0100, Dr. David Alan Gilbert wrote: > * Janosch Frank (fran...@linux.ibm.com) wrote: > > On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: > > > On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote: > > >> On 6/26/20 8:53 AM, David Hildenbrand wrote: > >

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Dr. David Alan Gilbert
* Janosch Frank (fran...@linux.ibm.com) wrote: > On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: > > On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote: > >> On 6/26/20 8:53 AM, David Hildenbrand wrote: > >>> Does this have any implications when probing with the 'none' machine? >

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Janosch Frank
On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: > On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote: >> On 6/26/20 8:53 AM, David Hildenbrand wrote: >>> Does this have any implications when probing with the 'none' machine? >> >> I'm not sure. In your case, I guess the cpu

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Daniel P . Berrangé
On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote: > On 6/26/20 8:53 AM, David Hildenbrand wrote: > > Does this have any implications when probing with the 'none' machine? > > I'm not sure. In your case, I guess the cpu bit would still show up > as before, so it

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Janosch Frank
On 6/26/20 8:53 AM, David Hildenbrand wrote: > Does this have any implications when probing with the 'none' machine? I'm not sure. In your case, I guess the cpu bit would still show up as before, so it would tell you base feature availability, but not whether you can use

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread David Hildenbrand
Does this have any implications when probing with the 'none' machine? >>> >>> I'm not sure. In your case, I guess the cpu bit would still show up >>> as before, so it would tell you base feature availability, but not >>> whether you can use the new configuration option. >>> >>> Since the HTL

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-25 Thread David Gibson
On Thu, Jun 25, 2020 at 09:06:05AM +0200, David Hildenbrand wrote: > >> Still unsure how to bring this new machine property and the cpu feature > >> together. Would be great to have the same interface everywhere, but > >> having two distinct command line objects depend on each other sucks. > > >

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-25 Thread Cornelia Huck
On Thu, 25 Jun 2020 08:59:00 +0200 David Hildenbrand wrote: > How do upper layers actually figure out if memory encryption etc is > available? on s390x, it's simply via the expanded host CPU model. > >>> > >>> Haven't really tackled that yet. But one way that works for multiple >

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-25 Thread David Hildenbrand
>> Still unsure how to bring this new machine property and the cpu feature >> together. Would be great to have the same interface everywhere, but >> having two distinct command line objects depend on each other sucks. > > Kinda, but the reality is that hardware - virtual and otherwise - >

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-25 Thread David Hildenbrand
> >> So it's wrapping architecture-specific data in a common >> parameter. Hmm. > > Well, I don't know I'd say "wrapping". You have a common parameter > that points to an object with a well defined interface. The available > implementations of that object will tend to be either zero or one per

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-24 Thread David Gibson
On Wed, Jun 24, 2020 at 09:06:48AM +0200, Cornelia Huck wrote: > On Mon, 22 Jun 2020 16:27:28 +0200 > Christian Borntraeger wrote: > > > On 19.06.20 04:05, David Gibson wrote: > > > A number of hardware platforms are implementing mechanisms whereby the > > > hypervisor does not have unfettered

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-24 Thread David Gibson
On Thu, Jun 25, 2020 at 03:47:23PM +1000, David Gibson wrote: > On Wed, Jun 24, 2020 at 09:06:48AM +0200, Cornelia Huck wrote: > > On Mon, 22 Jun 2020 16:27:28 +0200 > > Christian Borntraeger wrote: > > > > > On 19.06.20 04:05, David Gibson wrote: > > > > A number of hardware platforms are

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-24 Thread David Gibson
On Fri, Jun 19, 2020 at 12:04:25PM +0200, David Hildenbrand wrote: > >> However, once we have multiple options to protect a guest (memory > >> encryption, unmapping guest pages ,...) the name will no longer really > >> suffice to configure QEMU, no? > > > > That's why it takes a parameter. It

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-24 Thread David Gibson
On Mon, Jun 22, 2020 at 04:27:28PM +0200, Christian Borntraeger wrote: > On 19.06.20 04:05, David Gibson wrote: > > A number of hardware platforms are implementing mechanisms whereby the > > hypervisor does not have unfettered access to guest memory, in order > > to mitigate the security impact of

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-24 Thread David Gibson
On Mon, Jun 22, 2020 at 02:02:54PM +0200, Cornelia Huck wrote: > On Fri, 19 Jun 2020 12:10:13 +0200 > David Hildenbrand wrote: > > > On 19.06.20 12:05, Cornelia Huck wrote: > > > On Fri, 19 Jun 2020 11:56:49 +0200 > > > David Hildenbrand wrote: > > > > > > For now this series covers just

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-24 Thread Cornelia Huck
On Mon, 22 Jun 2020 16:27:28 +0200 Christian Borntraeger wrote: > On 19.06.20 04:05, David Gibson wrote: > > A number of hardware platforms are implementing mechanisms whereby the > > hypervisor does not have unfettered access to guest memory, in order > > to mitigate the security impact of a

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-22 Thread Christian Borntraeger
On 19.06.20 04:05, David Gibson wrote: > A number of hardware platforms are implementing mechanisms whereby the > hypervisor does not have unfettered access to guest memory, in order > to mitigate the security impact of a compromised hypervisor. > > AMD's SEV implements this with in-cpu memory

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-22 Thread Cornelia Huck
On Fri, 19 Jun 2020 12:10:13 +0200 David Hildenbrand wrote: > On 19.06.20 12:05, Cornelia Huck wrote: > > On Fri, 19 Jun 2020 11:56:49 +0200 > > David Hildenbrand wrote: > > > > For now this series covers just AMD SEV and POWER PEF. I'm hoping it > > can be extended to cover the

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-19 Thread David Hildenbrand
On 19.06.20 12:05, Cornelia Huck wrote: > On Fri, 19 Jun 2020 11:56:49 +0200 > David Hildenbrand wrote: > > For now this series covers just AMD SEV and POWER PEF. I'm hoping it > can be extended to cover the Intel and s390 mechanisms as well, > though. The only

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-19 Thread Cornelia Huck
On Fri, 19 Jun 2020 11:56:49 +0200 David Hildenbrand wrote: > >>> For now this series covers just AMD SEV and POWER PEF. I'm hoping it > >>> can be extended to cover the Intel and s390 mechanisms as well, > >>> though. > >> > >> The only approach on s390x to not glue command line properties

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-19 Thread David Hildenbrand
>> However, once we have multiple options to protect a guest (memory >> encryption, unmapping guest pages ,...) the name will no longer really >> suffice to configure QEMU, no? > > That's why it takes a parameter. It points to an object which can > itself have more properties to configure the

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-19 Thread David Hildenbrand
>> "host-trust-limitation" sounds like "I am the hypervisor, I configure >> limited trust into myself". Also, "untrusted-host" would be a little bit >> nicer (I think trust is a black/white thing). >> >> However, once we have multiple options to protect a guest (memory >> encryption, unmapping

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-19 Thread David Gibson
On Fri, Jun 19, 2020 at 10:28:22AM +0200, David Hildenbrand wrote: > On 19.06.20 04:05, David Gibson wrote: > > A number of hardware platforms are implementing mechanisms whereby the > > hypervisor does not have unfettered access to guest memory, in order > > to mitigate the security impact of a

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-19 Thread Cornelia Huck
On Fri, 19 Jun 2020 10:28:22 +0200 David Hildenbrand wrote: > On 19.06.20 04:05, David Gibson wrote: > > A number of hardware platforms are implementing mechanisms whereby the > > hypervisor does not have unfettered access to guest memory, in order > > to mitigate the security impact of a

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-19 Thread David Hildenbrand
On 19.06.20 04:05, David Gibson wrote: > A number of hardware platforms are implementing mechanisms whereby the > hypervisor does not have unfettered access to guest memory, in order > to mitigate the security impact of a compromised hypervisor. > > AMD's SEV implements this with in-cpu memory

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200619020602.118306-1-da...@gibson.dropbear.id.au/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH v3 0/9] Generalize memory encryption models

2020-06-18 Thread David Gibson
A number of hardware platforms are implementing mechanisms whereby the hypervisor does not have unfettered access to guest memory, in order to mitigate the security impact of a compromised hypervisor. AMD's SEV implements this with in-cpu memory encryption, and Intel has its own memory encryption