Re: [PATCH v3 00/14] LUKS: encryption slot management using amend interface

2020-05-04 Thread Maxim Levitsky
On Mon, 2020-05-04 at 11:19 +0100, Daniel P. Berrangé wrote: > On Sun, May 03, 2020 at 09:43:10PM +0300, Maxim Levitsky wrote: > > Hi! > > Here is the updated series of my patches, incorporating all the feedback I > > received. > > > > This implements the API interface that we agreed upon except

Re: [PATCH v3 00/14] LUKS: encryption slot management using amend interface

2020-05-04 Thread Daniel P . Berrangé
On Sun, May 03, 2020 at 09:43:10PM +0300, Maxim Levitsky wrote: > Hi! > Here is the updated series of my patches, incorporating all the feedback I > received. > > This implements the API interface that we agreed upon except that I merged the > LUKSKeyslotActive/LUKSKeyslotInactive union into a st

Re: [PATCH v3 00/14] LUKS: encryption slot management using amend interface

2020-05-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200503184324.12506-1-mlevi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200503184324.12506-1-mlevi...@redhat.com Subject: [PATCH v3 00/14] LUKS: encryption slot management

[PATCH v3 00/14] LUKS: encryption slot management using amend interface

2020-05-03 Thread Maxim Levitsky
Hi! Here is the updated series of my patches, incorporating all the feedback I received. This implements the API interface that we agreed upon except that I merged the LUKSKeyslotActive/LUKSKeyslotInactive union into a struct because otherwise I need nested unions which are not supported currentl