Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Paolo Bonzini
On 21/09/20 12:54, Alex Bennée wrote: > Something is breaking when switching to a branch with this on from > current master: > > Linking target qemu-hppa > /usr/bin/ld: libcommon.fa.p/disas_alpha.c.o: in function `print_insn_alpha': > /home/alex/lsrc/qemu.git/builds/all/../../disas/alpha.c:1

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Yonggang Luo
On Mon, Sep 21, 2020 at 7:06 PM Alex Bennée wrote: > > > Alex Bennée writes: > > > Richard Henderson writes: > > > >> There are better ways to do this, e.g. meson cmake subproject, > >> but that requires cmake 3.7 and some of our CI environments > >> only provide cmake 3.5. > >> > >> Nor can we

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> There are better ways to do this, e.g. meson cmake subproject, >> but that requires cmake 3.7 and some of our CI environments >> only provide cmake 3.5. >> >> Nor can we add a meson.build file to capstone/, because the git >> submodule would

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Alex Bennée
Richard Henderson writes: > There are better ways to do this, e.g. meson cmake subproject, > but that requires cmake 3.7 and some of our CI environments > only provide cmake 3.5. > > Nor can we add a meson.build file to capstone/, because the git > submodule would then always report "untracked

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Yonggang Luo
On Fri, Sep 18, 2020 at 8:58 PM Paolo Bonzini wrote: > > On 18/09/20 10:42, 罗勇刚(Yonggang Luo) wrote: > > I also have a question that how about convert > > --disable-capstone) capstone="no" > > ;; > > --enable-capstone) capstone="yes" > > ;; > > to > > --disable-capstone) capstone="disa

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Paolo Bonzini
On 18/09/20 10:42, 罗勇刚(Yonggang Luo) wrote: > I also have a question that how about convert >   --disable-capstone) capstone="no" >   ;; >   --enable-capstone) capstone="yes" >   ;; > to  >     --disable-capstone) capstone="disabled" >   ;; >   --enable-capstone) capstone="enabled" >   ;; > > for

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Yonggang Luo
On Fri, Sep 18, 2020 at 4:19 PM Paolo Bonzini wrote: > > On 18/09/20 01:57, Richard Henderson wrote: > > There are better ways to do this, e.g. meson cmake subproject, > > but that requires cmake 3.7 and some of our CI environments > > only provide cmake 3.5. > > > > Nor can we add a meson.build f

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Paolo Bonzini
On 18/09/20 01:57, Richard Henderson wrote: > There are better ways to do this, e.g. meson cmake subproject, > but that requires cmake 3.7 and some of our CI environments > only provide cmake 3.5. > > Nor can we add a meson.build file to capstone/, because the git > submodule would then always rep

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Yonggang Luo
On Fri, Sep 18, 2020 at 7:59 AM Richard Henderson < richard.hender...@linaro.org> wrote: > > There are better ways to do this, e.g. meson cmake subproject, > but that requires cmake 3.7 and some of our CI environments > only provide cmake 3.5. > > Nor can we add a meson.build file to capstone/, bec

[PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-17 Thread Richard Henderson
There are better ways to do this, e.g. meson cmake subproject, but that requires cmake 3.7 and some of our CI environments only provide cmake 3.5. Nor can we add a meson.build file to capstone/, because the git submodule would then always report "untracked files". Fixing that would require creati