Re: [PATCH v3 01/46] net: add qemu_{configure,create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 15:33 +, Peter Maydell wrote: > On Fri, 26 Jan 2024 at 15:20, David Woodhouse wrote: > > > > On Fri, 2024-01-26 at 14:43 +, Peter Maydell wrote: > > > > > > > +NICInfo *qemu_find_nic_info(const char *typename, bool match_default, > > > > +   

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread Peter Maydell
On Fri, 26 Jan 2024 at 15:20, David Woodhouse wrote: > > On Fri, 2024-01-26 at 14:43 +, Peter Maydell wrote: > > > > > +NICInfo *qemu_find_nic_info(const char *typename, bool match_default, > > > +const char *alias); > > > +bool

Re: [PATCH v3 01/46] net: add qemu_{configure,create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 14:43 +, Peter Maydell wrote: > > > +NICInfo *qemu_find_nic_info(const char *typename, bool match_default, > > +    const char *alias); > > +bool qemu_configure_nic_device(DeviceState *dev, bool match_default, > > +  

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread Peter Maydell
On Mon, 8 Jan 2024 at 20:49, David Woodhouse wrote: > > From: David Woodhouse > > Most code which directly accesses nd_table[] and nb_nics uses them for > one of two things. Either "I have created a NIC device and I'd like a > configuration for it", or "I will create a NIC device *if* there is a

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread Thomas Huth
On 26/01/2024 15.34, David Woodhouse wrote: On Fri, 2024-01-26 at 15:24 +0100, Thomas Huth wrote: On 26/01/2024 15.16, David Woodhouse wrote: On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote: +/* "Please create a device, if you have a configuration for it" */ +DeviceState

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 15:24 +0100, Thomas Huth wrote: > On 26/01/2024 15.16, David Woodhouse wrote: > > On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote: > > > > > > > +/* "Please create a device, if you have a configuration for it" */ > > > > +DeviceState *qemu_create_nic_device(const char

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread Thomas Huth
On 26/01/2024 15.16, David Woodhouse wrote: On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote: +/* "Please create a device, if you have a configuration for it" */ +DeviceState *qemu_create_nic_device(const char *typename, bool match_default, +    const char

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote: > > > +/* "Please create a device, if you have a configuration for it" */ > > +DeviceState *qemu_create_nic_device(const char *typename, bool > > match_default, > > +    const char *alias) > > +{ > > +   

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Most code which directly accesses nd_table[] and nb_nics uses them for one of two things. Either "I have created a NIC device and I'd like a configuration for it", or "I will create a NIC device *if* there is a configuration for

[PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Most code which directly accesses nd_table[] and nb_nics uses them for one of two things. Either "I have created a NIC device and I'd like a configuration for it", or "I will create a NIC device *if* there is a configuration for it". With some variants on the theme around