Re: [PATCH v3 02/14] hw/display/apple-gfx: Adds PCI implementation

2024-10-02 Thread Phil Dennis-Jordan
On Wed, 2 Oct 2024 at 09:14, Akihiko Odaki wrote: > On 2024/09/28 17:57, Phil Dennis-Jordan wrote: > > This change wires up the PCI variant of the paravirtualised > > graphics device, mainly useful for x86-64 macOS guests, implemented > > by macOS's ParavirtualizedGraphics.framework. It builds on

Re: [PATCH v3 02/14] hw/display/apple-gfx: Adds PCI implementation

2024-10-02 Thread Akihiko Odaki
On 2024/09/28 17:57, Phil Dennis-Jordan wrote: This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. S

Re: [PATCH v3 02/14] hw/display/apple-gfx: Adds PCI implementation

2024-09-28 Thread Phil Dennis-Jordan
On Sat, 28 Sept 2024 at 12:39, BALATON Zoltan wrote: > > +typedef struct AppleGFXPCIState { > > +PCIDevice parent_obj; > > + > > +AppleGFXState common; > > +} AppleGFXPCIState; > > You don't need typedef here because OBJECT_DECLARE_SIMPLE_TYPE will add > that. You can also put the struct

Re: [PATCH v3 02/14] hw/display/apple-gfx: Adds PCI implementation

2024-09-28 Thread BALATON Zoltan
On Sat, 28 Sep 2024, Phil Dennis-Jordan wrote: This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. S

[PATCH v3 02/14] hw/display/apple-gfx: Adds PCI implementation

2024-09-28 Thread Phil Dennis-Jordan
This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. Signed-off-by: Phil Dennis-Jordan --- hw/display