Re: [PATCH v3 02/16] hw/i386/amd_iommu: Omit errp for pci_add_capability

2022-10-26 Thread Markus Armbruster
Akihiko Odaki writes: > Omitting errp for pci_add_capability() causes it to abort if > capabilities overlap. This behavior is appropriate heare because all of Typo: here Same for later patches. > the capabilities set in this device are defined in the program and > their overlap should not

[PATCH v3 02/16] hw/i386/amd_iommu: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki