Re: [PATCH v3 05/17] plugins: scoreboard API

2024-02-11 Thread Pierrick Bouvier
On 2/11/24 23:13, Richard Henderson wrote: On 2/11/24 04:26, Pierrick Bouvier wrote: On 2/11/24 04:41, Richard Henderson wrote: On 2/6/24 19:59, Pierrick Bouvier wrote: Why a hash table?  All you want is to be able to iterate through all, and add/remove easily.  Seems like QLIST from would b

Re: [PATCH v3 05/17] plugins: scoreboard API

2024-02-11 Thread Richard Henderson
On 2/11/24 04:26, Pierrick Bouvier wrote: On 2/11/24 04:41, Richard Henderson wrote: On 2/6/24 19:59, Pierrick Bouvier wrote: Why a hash table?  All you want is to be able to iterate through all, and add/remove easily.  Seems like QLIST from would be better, and the QLIST_ENTRY member would

Re: [PATCH v3 05/17] plugins: scoreboard API

2024-02-11 Thread Pierrick Bouvier
On 2/11/24 04:41, Richard Henderson wrote: On 2/6/24 19:59, Pierrick Bouvier wrote: Why a hash table?  All you want is to be able to iterate through all, and add/remove easily.  Seems like QLIST from would be better, and the QLIST_ENTRY member would make struct qemu_plugin_scoreboard useful.

Re: [PATCH v3 05/17] plugins: scoreboard API

2024-02-10 Thread Richard Henderson
On 2/6/24 19:59, Pierrick Bouvier wrote: Why a hash table?  All you want is to be able to iterate through all, and add/remove easily.  Seems like QLIST from would be better, and the QLIST_ENTRY member would make struct qemu_plugin_scoreboard useful. Thought that having O(1) removal was a ni

Re: [PATCH v3 05/17] plugins: scoreboard API

2024-02-06 Thread Pierrick Bouvier
On 2/7/24 07:21, Richard Henderson wrote: On 2/6/24 19:24, Pierrick Bouvier wrote: We introduce a cpu local storage, automatically managed (and extended) by QEMU itself. Plugin allocate a scoreboard, and don't have to deal with how many cpus are launched. This API will be used by new inline fun

Re: [PATCH v3 05/17] plugins: scoreboard API

2024-02-06 Thread Richard Henderson
On 2/6/24 19:24, Pierrick Bouvier wrote: We introduce a cpu local storage, automatically managed (and extended) by QEMU itself. Plugin allocate a scoreboard, and don't have to deal with how many cpus are launched. This API will be used by new inline functions but callbacks can benefit from this

[PATCH v3 05/17] plugins: scoreboard API

2024-02-06 Thread Pierrick Bouvier
We introduce a cpu local storage, automatically managed (and extended) by QEMU itself. Plugin allocate a scoreboard, and don't have to deal with how many cpus are launched. This API will be used by new inline functions but callbacks can benefit from this as well. This way, they can operate without