Re: [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-23 Thread Willian Rampazzo
On Sun, Nov 8, 2020 at 7:27 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > --- > .gitlab-ci.yml | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 0ef814764a0..d4526323169 100644 > ---

Re: [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/12/20 9:31 PM, Wainer dos Santos Moschetta wrote: > > On 11/12/20 5:02 AM, Thomas Huth wrote: >> On 10/11/2020 21.42, Wainer dos Santos Moschetta wrote: >>> Once Cleber said "acceptance" wasn't  a good name for those tests. >>> Indeed >>> "integration" is widely used, so okay for this renami

Re: [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-12 Thread Wainer dos Santos Moschetta
On 11/12/20 5:02 AM, Thomas Huth wrote: On 10/11/2020 21.42, Wainer dos Santos Moschetta wrote: Once Cleber said "acceptance" wasn't  a good name for those tests. Indeed "integration" is widely used, so okay for this renaming. Should we maybe also rename the folder and "make check-acceptance"

Re: [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-11 Thread Thomas Huth
On 10/11/2020 21.42, Wainer dos Santos Moschetta wrote: > Once Cleber said "acceptance" wasn't  a good name for those tests. Indeed > "integration" is widely used, so okay for this renaming. Should we maybe also rename the folder and "make check-acceptance" into "make check-integration" ? Thomas

Re: [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-10 Thread Wainer dos Santos Moschetta
Once Cleber said "acceptance" wasn't  a good name for those tests. Indeed "integration" is widely used, so okay for this renaming. On 11/8/20 8:19 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 18 +- 1 file changed, 9 insertions

[PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0ef814764a0..d4526323169 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -42,7 +42,7 @@ include: - find .