Re: [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-18 Thread Philippe Mathieu-Daudé
On 6/18/21 1:49 AM, BALATON Zoltan wrote: > On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: >> On 6/16/21 10:01 PM, BALATON Zoltan wrote: >>> Having a send_recv in one func >>> allowed to avoid if-else in some places like these but if you think it's >>> better without this function at all I can

Re: [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-17 Thread BALATON Zoltan
On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: On 6/16/21 10:01 PM, BALATON Zoltan wrote: On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: On 6/16/21 9:16 PM, Corey Minyard wrote: On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote: Instead of using the confuse i2c_se

Re: [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-16 Thread Corey Minyard
On Thu, Jun 17, 2021 at 01:09:05AM +0200, BALATON Zoltan wrote: > On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: > > On 6/16/21 10:01 PM, BALATON Zoltan wrote: > > > On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: > > > > On 6/16/21 9:16 PM, Corey Minyard wrote: > > > > > On Wed, Jun 16, 202

Re: [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-16 Thread BALATON Zoltan
On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: On 6/16/21 10:01 PM, BALATON Zoltan wrote: On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: On 6/16/21 9:16 PM, Corey Minyard wrote: On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote: Instead of using the confuse i2c_se

Re: [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-16 Thread Philippe Mathieu-Daudé
On 6/16/21 10:01 PM, BALATON Zoltan wrote: > On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: >> On 6/16/21 9:16 PM, Corey Minyard wrote: >>> On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote: Instead of using the confuse i2c_send_recv(), rewrite to directly call i2

Re: [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-16 Thread BALATON Zoltan
On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: On 6/16/21 9:16 PM, Corey Minyard wrote: On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote: Instead of using the confuse i2c_send_recv(), rewrite to directly call i2c_recv() & i2c_send(), resulting in code easire to review.

Re: [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-16 Thread Philippe Mathieu-Daudé
On 6/16/21 9:16 PM, Corey Minyard wrote: > On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote: >> Instead of using the confuse i2c_send_recv(), rewrite to directly >> call i2c_recv() & i2c_send(), resulting in code easire to review. >> >> Signed-off-by: Philippe Mathieu-Daudé >

Re: [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-16 Thread Corey Minyard
On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote: > Instead of using the confuse i2c_send_recv(), rewrite to directly > call i2c_recv() & i2c_send(), resulting in code easire to review. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i2c/ppc4xx_i2c.c | 13 -

Re: [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-16 Thread Richard Henderson
On 6/16/21 9:14 AM, Philippe Mathieu-Daudé wrote: Instead of using the confuse i2c_send_recv(), rewrite to directly call i2c_recv() & i2c_send(), resulting in code easire to review. easier. Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/ppc4xx_i2c.c | 13 - 1 file changed, 8

[PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()

2021-06-16 Thread Philippe Mathieu-Daudé
Instead of using the confuse i2c_send_recv(), rewrite to directly call i2c_recv() & i2c_send(), resulting in code easire to review. Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/ppc4xx_i2c.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/i2c/ppc4xx_i2c.c