Re: [PATCH v3 07/33] serial: register vmsd with DeviceClass

2019-11-20 Thread Marc-André Lureau
Hi On Wed, Nov 20, 2019 at 10:54 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > On Tue, Nov 19, 2019 at 2:35 PM Peter Maydell > > wrote: > > > > > > On Tue, 19 Nov 2019 at 10:23, Marc-André Lureau > > > wrote: > > > > On Mon, Nov 18, 2019 at 6:

Re: [PATCH v3 07/33] serial: register vmsd with DeviceClass

2019-11-20 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > On Tue, Nov 19, 2019 at 2:35 PM Peter Maydell > wrote: > > > > On Tue, 19 Nov 2019 at 10:23, Marc-André Lureau > > wrote: > > > On Mon, Nov 18, 2019 at 6:22 PM Peter Maydell > > > wrote: > > > > Did you test whether migration still work

Re: [PATCH v3 07/33] serial: register vmsd with DeviceClass

2019-11-19 Thread Marc-André Lureau
On Tue, Nov 19, 2019 at 2:35 PM Peter Maydell wrote: > > On Tue, 19 Nov 2019 at 10:23, Marc-André Lureau > wrote: > > On Mon, Nov 18, 2019 at 6:22 PM Peter Maydell > > wrote: > > > Did you test whether migration still works from a QEMU > > > version without this patch to one with it? (The migra

Re: [PATCH v3 07/33] serial: register vmsd with DeviceClass

2019-11-19 Thread Peter Maydell
On Tue, 19 Nov 2019 at 10:23, Marc-André Lureau wrote: > On Mon, Nov 18, 2019 at 6:22 PM Peter Maydell > wrote: > > Did you test whether migration still works from a QEMU > > version without this patch to one with it? (The migration > > Yes, I thought I did test correctly, but I realized testing

Re: [PATCH v3 07/33] serial: register vmsd with DeviceClass

2019-11-19 Thread Marc-André Lureau
On Mon, Nov 18, 2019 at 6:22 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:33, Marc-André Lureau > wrote: > > > > QOM-ify further. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/char/serial.c | 13 ++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > diff

Re: [PATCH v3 07/33] serial: register vmsd with DeviceClass

2019-11-18 Thread Peter Maydell
On Wed, 23 Oct 2019 at 18:33, Marc-André Lureau wrote: > > QOM-ify further. > > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index c839035fdd..4af8b0ce4c 100

[PATCH v3 07/33] serial: register vmsd with DeviceClass

2019-10-23 Thread Marc-André Lureau
QOM-ify further. Signed-off-by: Marc-André Lureau --- hw/char/serial.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index c839035fdd..4af8b0ce4c 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -990,8 +990,7 @@ Seri