Re: [PATCH v3 08/10] virtiofsd: Add inodes_by_handle hash table

2021-08-10 Thread Vivek Goyal
On Tue, Aug 10, 2021 at 04:13:44PM +0200, Hanna Reitz wrote: > On 10.08.21 16:07, Vivek Goyal wrote: > > On Mon, Aug 09, 2021 at 06:47:18PM +0200, Hanna Reitz wrote: > > > On 09.08.21 18:10, Vivek Goyal wrote: > > > > On Fri, Jul 30, 2021 at 05:01:32PM +0200, Max Reitz wrote: > > > > > Currently, l

Re: [PATCH v3 08/10] virtiofsd: Add inodes_by_handle hash table

2021-08-10 Thread Hanna Reitz
On 10.08.21 16:07, Vivek Goyal wrote: On Mon, Aug 09, 2021 at 06:47:18PM +0200, Hanna Reitz wrote: On 09.08.21 18:10, Vivek Goyal wrote: On Fri, Jul 30, 2021 at 05:01:32PM +0200, Max Reitz wrote: Currently, lo_inode.fhandle is always NULL and so always keep an O_PATH FD in lo_inode.fd. Theref

Re: [PATCH v3 08/10] virtiofsd: Add inodes_by_handle hash table

2021-08-10 Thread Vivek Goyal
On Mon, Aug 09, 2021 at 06:47:18PM +0200, Hanna Reitz wrote: > On 09.08.21 18:10, Vivek Goyal wrote: > > On Fri, Jul 30, 2021 at 05:01:32PM +0200, Max Reitz wrote: > > > Currently, lo_inode.fhandle is always NULL and so always keep an O_PATH > > > FD in lo_inode.fd. Therefore, when the respective

Re: [PATCH v3 08/10] virtiofsd: Add inodes_by_handle hash table

2021-08-09 Thread Hanna Reitz
On 09.08.21 18:10, Vivek Goyal wrote: On Fri, Jul 30, 2021 at 05:01:32PM +0200, Max Reitz wrote: Currently, lo_inode.fhandle is always NULL and so always keep an O_PATH FD in lo_inode.fd. Therefore, when the respective inode is unlinked, its inode ID will remain in use until we drop our lo_inod

Re: [PATCH v3 08/10] virtiofsd: Add inodes_by_handle hash table

2021-08-09 Thread Vivek Goyal
On Fri, Jul 30, 2021 at 05:01:32PM +0200, Max Reitz wrote: > Currently, lo_inode.fhandle is always NULL and so always keep an O_PATH > FD in lo_inode.fd. Therefore, when the respective inode is unlinked, > its inode ID will remain in use until we drop our lo_inode (and > lo_inode_put() thus closes

[PATCH v3 08/10] virtiofsd: Add inodes_by_handle hash table

2021-07-30 Thread Max Reitz
Currently, lo_inode.fhandle is always NULL and so always keep an O_PATH FD in lo_inode.fd. Therefore, when the respective inode is unlinked, its inode ID will remain in use until we drop our lo_inode (and lo_inode_put() thus closes the FD). Therefore, lo_find() can safely use the inode ID as an l