Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-19 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > When the inode_file_handles option is set, try to generate a file handle > for new inodes instead of opening an O_PATH FD. > > Being able to open these again will require CAP_DAC_READ_SEARCH, so the > description text tells the user they will also need to s

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-18 Thread Hanna Reitz
On 18.08.21 15:32, Vivek Goyal wrote: On Tue, Aug 17, 2021 at 08:14:46PM -0400, Vivek Goyal wrote: On Tue, Aug 17, 2021 at 03:45:19PM -0400, Vivek Goyal wrote: On Tue, Aug 17, 2021 at 10:27:16AM +0200, Hanna Reitz wrote: On 16.08.21 21:44, Vivek Goyal wrote: On Wed, Aug 11, 2021 at 08:41:18AM

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-18 Thread Vivek Goyal
On Tue, Aug 17, 2021 at 08:14:46PM -0400, Vivek Goyal wrote: > On Tue, Aug 17, 2021 at 03:45:19PM -0400, Vivek Goyal wrote: > > On Tue, Aug 17, 2021 at 10:27:16AM +0200, Hanna Reitz wrote: > > > On 16.08.21 21:44, Vivek Goyal wrote: > > > > On Wed, Aug 11, 2021 at 08:41:18AM +0200, Hanna Reitz wrot

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-17 Thread Vivek Goyal
On Tue, Aug 17, 2021 at 03:45:19PM -0400, Vivek Goyal wrote: > On Tue, Aug 17, 2021 at 10:27:16AM +0200, Hanna Reitz wrote: > > On 16.08.21 21:44, Vivek Goyal wrote: > > > On Wed, Aug 11, 2021 at 08:41:18AM +0200, Hanna Reitz wrote: > > > > > > [..] > > > > > > But given the inotify complications,

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-17 Thread Vivek Goyal
On Tue, Aug 17, 2021 at 10:27:16AM +0200, Hanna Reitz wrote: > On 16.08.21 21:44, Vivek Goyal wrote: > > On Wed, Aug 11, 2021 at 08:41:18AM +0200, Hanna Reitz wrote: > > > > [..] > > > > > But given the inotify complications, there’s really a good reason we > > > > > should > > > > > use mountinf

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-17 Thread Hanna Reitz
On 16.08.21 21:44, Vivek Goyal wrote: On Wed, Aug 11, 2021 at 08:41:18AM +0200, Hanna Reitz wrote: [..] But given the inotify complications, there’s really a good reason we should use mountinfo. It’s a bit tricky because our sandboxing prevents easy access to mountinfo, but if that’s the only

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-16 Thread Vivek Goyal
On Wed, Aug 11, 2021 at 08:41:18AM +0200, Hanna Reitz wrote: [..] > > > But given the inotify complications, there’s really a good reason we > > > should > > > use mountinfo. > > > > > > > > It’s a bit tricky because our sandboxing prevents easy access to > > > > > mountinfo, > > > > > but if t

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-10 Thread Hanna Reitz
On 10.08.21 17:57, Vivek Goyal wrote: On Tue, Aug 10, 2021 at 05:26:15PM +0200, Hanna Reitz wrote: On 10.08.21 17:23, Vivek Goyal wrote: On Tue, Aug 10, 2021 at 10:32:55AM +0200, Hanna Reitz wrote: On 09.08.21 20:41, Vivek Goyal wrote: On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-10 Thread Vivek Goyal
On Tue, Aug 10, 2021 at 05:26:15PM +0200, Hanna Reitz wrote: > On 10.08.21 17:23, Vivek Goyal wrote: > > On Tue, Aug 10, 2021 at 10:32:55AM +0200, Hanna Reitz wrote: > > > On 09.08.21 20:41, Vivek Goyal wrote: > > > > On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote: > > > > > When the ino

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-10 Thread Hanna Reitz
On 10.08.21 17:23, Vivek Goyal wrote: On Tue, Aug 10, 2021 at 10:32:55AM +0200, Hanna Reitz wrote: On 09.08.21 20:41, Vivek Goyal wrote: On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote: When the inode_file_handles option is set, try to generate a file handle for new inodes instead of

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-10 Thread Vivek Goyal
On Tue, Aug 10, 2021 at 10:32:55AM +0200, Hanna Reitz wrote: > On 09.08.21 20:41, Vivek Goyal wrote: > > On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote: > > > When the inode_file_handles option is set, try to generate a file handle > > > for new inodes instead of opening an O_PATH FD. >

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-10 Thread Hanna Reitz
On 09.08.21 20:41, Vivek Goyal wrote: On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote: When the inode_file_handles option is set, try to generate a file handle for new inodes instead of opening an O_PATH FD. Being able to open these again will require CAP_DAC_READ_SEARCH, so the descr

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-09 Thread Vivek Goyal
On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote: > When the inode_file_handles option is set, try to generate a file handle > for new inodes instead of opening an O_PATH FD. > > Being able to open these again will require CAP_DAC_READ_SEARCH, so the > description text tells the user they

[PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-07-30 Thread Max Reitz
When the inode_file_handles option is set, try to generate a file handle for new inodes instead of opening an O_PATH FD. Being able to open these again will require CAP_DAC_READ_SEARCH, so the description text tells the user they will also need to specify -o modcaps=+dac_read_search. Generating a