Re: [PATCH v3 1/2] meson: convert pc-bios/keymaps/Makefile

2020-08-23 Thread Paolo Bonzini
I think it should just add build_by_default: false with a comment explaining why. Paolo Il lun 24 ago 2020, 07:23 Gerd Hoffmann ha scritto: > > --- a/pc-bios/meson.build > > +++ b/pc-bios/meson.build > > @@ -25,3 +25,4 @@ if 'DECOMPRESS_EDK2_BLOBS' in config_host > > endif > > > > subdir('des

Re: [PATCH v3 1/2] meson: convert pc-bios/keymaps/Makefile

2020-08-23 Thread Gerd Hoffmann
> --- a/pc-bios/meson.build > +++ b/pc-bios/meson.build > @@ -25,3 +25,4 @@ if 'DECOMPRESS_EDK2_BLOBS' in config_host > endif > > subdir('descriptors') > +subdir('keymaps') Hmm, this hooks up the keymaps update to the default build. Not a good plan. The output is not static, but defaults on t

[PATCH v3 1/2] meson: convert pc-bios/keymaps/Makefile

2020-08-21 Thread Philippe Mathieu-Daudé
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini Tested-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- Makefile| 8 -- pc-bios/keymaps/Makefile| 56 - pc-bios/keymaps/m