Re: [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.

2023-05-03 Thread Harsh Prateek Bora
On 5/4/23 02:19, Daniel Henrique Barboza wrote: I squashed in this change to fix it: diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 241d9e27e5..424f2e1741 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -75,7 +75,7 @@ void ppc_set_cr(CPUPPCState *env, uint64_t cr)   }  

Re: [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.

2023-05-03 Thread Daniel Henrique Barboza
This patch breaks linux-user build as follows: [23/214] Compiling C object libqemu-ppc64-linux-user.fa.p/linux-user_elfload.c.o FAILED: libqemu-ppc64-linux-user.fa.p/linux-user_elfload.c.o cc -m64 -mcx16 -Ilibqemu-ppc64-linux-user.fa.p -I. -I.. -Itarget/ppc -I../target/ppc -I../common-user/host/

Re: [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.

2023-05-03 Thread Richard Henderson
On 5/3/23 10:36, Harsh Prateek Bora wrote: The bits in cr reg are grouped into eight 4-bit fields represented by env->crf[8] and the related calculations should be abstracted to keep the calling routines simpler to read. This is a step towards cleaning up the related/calling code for better reada

[PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.

2023-05-03 Thread Harsh Prateek Bora
The bits in cr reg are grouped into eight 4-bit fields represented by env->crf[8] and the related calculations should be abstracted to keep the calling routines simpler to read. This is a step towards cleaning up the related/calling code for better readability. Signed-off-by: Harsh Prateek Bora R