Re: [PATCH v3 1/3] arm: move KVM breakpoints helpers

2023-02-13 Thread Peter Maydell
On Mon, 13 Feb 2023 at 16:28, Francesco Cagnin wrote: > > > New files must all start with the usual boilerplate > > comment stating the license and copyright. Sorry I didn't > > notice this in previous rounds of review. > > Pardon my naivety, since the new file only contains code from > 'target/ar

Re: [PATCH v3 1/3] arm: move KVM breakpoints helpers

2023-02-13 Thread Francesco Cagnin
> New files must all start with the usual boilerplate > comment stating the license and copyright. Sorry I didn't > notice this in previous rounds of review. Pardon my naivety, since the new file only contains code from 'target/arm/kvm64.c', should I just copy the license and copyright comments fr

Re: [PATCH v3 1/3] arm: move KVM breakpoints helpers

2023-02-10 Thread Peter Maydell
On Sat, 14 Jan 2023 at 16:13, wrote: > > From: Francesco Cagnin > > These helpers will be also used for HVF. Aside from reformatting a > couple of comments for 'checkpatch.pl' and updating meson to compile > 'hyp_gdbstub.c', this is just code motion. > > Signed-off-by: Francesco Cagnin > --- >

Re: [PATCH v3 1/3] arm: move KVM breakpoints helpers

2023-01-15 Thread Alex Bennée
francesco.cag...@gmail.com writes: > From: Francesco Cagnin > > These helpers will be also used for HVF. Aside from reformatting a > couple of comments for 'checkpatch.pl' and updating meson to compile > 'hyp_gdbstub.c', this is just code motion. > > Signed-off-by: Francesco Cagnin Haven't I

[PATCH v3 1/3] arm: move KVM breakpoints helpers

2023-01-14 Thread francesco . cagnin
From: Francesco Cagnin These helpers will be also used for HVF. Aside from reformatting a couple of comments for 'checkpatch.pl' and updating meson to compile 'hyp_gdbstub.c', this is just code motion. Signed-off-by: Francesco Cagnin --- target/arm/hyp_gdbstub.c | 242 +