> > Thanks for helpping me verify this!!
> >
> > EMM, but I'm still not understanding how this approach distinguishes
> > whether hw/core/cpu-common.c needs the header (include/exec/cpu-common.h)
> > directly or just include/exec/memory.h needs that header? For the latter,
> > the header needn't b
On 11/3/24 16:44, Zhao Liu wrote:
Hi Philippe,
On Mon, Mar 11, 2024 at 12:40:23PM +0100, Philippe Mathieu-Daudé wrote:
Date: Mon, 11 Mar 2024 12:40:23 +0100
From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 1/3] hw/core: Cleanup unused included headers in
cpu-common.c
On 11/3/24 08:56
Hi Philippe,
On Mon, Mar 11, 2024 at 12:40:23PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 11 Mar 2024 12:40:23 +0100
> From: Philippe Mathieu-Daudé
> Subject: Re: [PATCH v3 1/3] hw/core: Cleanup unused included headers in
> cpu-common.c
>
> On 11/3/24 08:56, Zhao L
On Mon, 11 Mar 2024 at 12:40, Philippe Mathieu-Daudé wrote:
>
> On 11/3/24 08:56, Zhao Liu wrote:
> > From: Zhao Liu
> >
> > Remove unused headers in cpu-common.c:
> > * qemu/notify.h
> > * exec/cpu-common.h
> > * qemu/error-report.h
> > * qemu/qemu-print.h
> >
> > Tested by "./configure" and the
On 11/3/24 08:56, Zhao Liu wrote:
From: Zhao Liu
Remove unused headers in cpu-common.c:
* qemu/notify.h
* exec/cpu-common.h
* qemu/error-report.h
* qemu/qemu-print.h
Tested by "./configure" and then "make".
This isn't often enough. The safest way to catch implicit
includes is to add #error i
From: Zhao Liu
Remove unused headers in cpu-common.c:
* qemu/notify.h
* exec/cpu-common.h
* qemu/error-report.h
* qemu/qemu-print.h
Tested by "./configure" and then "make".
Signed-off-by: Zhao Liu
---
hw/core/cpu-common.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/core/cpu-comm
