Re: [PATCH v3 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

2022-02-16 Thread David Hildenbrand
> /* Really format SS_b, but we pack both lengths into one argument > @@ -735,6 +753,9 @@ > /* PACK UNICODE */ > C(0xe100, PKU, SS_f, E2, la1, a2, 0, 0, pku, 0) > +/* POPULATION COUNT */ > +C(0xb9e1, POPCNT, RRE, PC, 0, r2_o, r1, 0, popcnt, nz64) You actually need

Re: [PATCH v3 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

2022-02-16 Thread David Hildenbrand
On 16.02.22 11:31, David Hildenbrand wrote: >> +static DisasJumpType op_sel(DisasContext *s, DisasOps *o) >> +{ >> +DisasCompare c; >> +disas_jcc(s, , get_field(s, m4)); >> +tcg_gen_movcond_i64(c.cond, o->out, c.u.s64.a, c.u.s64.b, >> +o->in1, o->in2); >> +

Re: [PATCH v3 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

2022-02-16 Thread David Hildenbrand
> +static DisasJumpType op_sel(DisasContext *s, DisasOps *o) > +{ > +DisasCompare c; > +disas_jcc(s, , get_field(s, m4)); > +tcg_gen_movcond_i64(c.cond, o->out, c.u.s64.a, c.u.s64.b, > +o->in1, o->in2); > +free_compare(); > +return DISAS_NEXT; > +} I

Re: [PATCH v3 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

2022-02-16 Thread David Hildenbrand
On 15.02.22 21:26, David Miller wrote: > resolves: https://gitlab.com/qemu-project/qemu/-/issues/737 > implements: > AND WITH COMPLEMENT (NCRK, NCGRK) > NAND (NNRK, NNGRK) > NOT EXCLUSIVE OR (NXRK, NXGRK) > NOR (NORK, NOGRK) > OR WITH COMPLEMENT(OCRK,

[PATCH v3 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

2022-02-15 Thread David Miller
resolves: https://gitlab.com/qemu-project/qemu/-/issues/737 implements: AND WITH COMPLEMENT (NCRK, NCGRK) NAND (NNRK, NNGRK) NOT EXCLUSIVE OR (NXRK, NXGRK) NOR (NORK, NOGRK) OR WITH COMPLEMENT(OCRK, OCGRK) SELECT(SELR, SELGR) SELECT