Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-16 Thread Markus Armbruster
Alexey Kirillov writes: > 08.09.2020, 17:32, "Markus Armbruster" : >> Eric Blake writes: >> >>>  On 9/7/20 7:39 AM, Markus Armbruster wrote: >>> >>  This is union Netdev plus a common member @peer-id, less the variant >>  members for NetClientDriver values 'nic' and 'hubport'. >> >>>

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-16 Thread Alexey Kirillov
08.09.2020, 17:32, "Markus Armbruster" : > Eric Blake writes: > >>  On 9/7/20 7:39 AM, Markus Armbruster wrote: >> >  This is union Netdev plus a common member @peer-id, less the variant >  members for NetClientDriver values 'nic' and 'hubport'. > >  Can 'type: 'nic' and 'type': 'h

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-09 Thread Alexey Kirillov
09.09.2020, 14:41, "Markus Armbruster" : > Alexey Kirillov writes: > >>  07.09.2020, 15:40, "Markus Armbruster" : >>>  Alexey Kirillov writes: >>>   Hi!   02.09.2020, 14:23, "Markus Armbruster" : >   Alexey Kirillov writes: > >>    Add a qmp command that provides infor

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-09 Thread Markus Armbruster
Alexey Kirillov writes: > 07.09.2020, 15:40, "Markus Armbruster" : >> Alexey Kirillov writes: >> >>>  Hi! >>> >>>  02.09.2020, 14:23, "Markus Armbruster" :  Alexey Kirillov writes: >   Add a qmp command that provides information about currently attached >   backend network dev

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-08 Thread Alexey Kirillov
07.09.2020, 15:40, "Markus Armbruster" : > Alexey Kirillov writes: > >>  Hi! >> >>  02.09.2020, 14:23, "Markus Armbruster" : >>>  Alexey Kirillov writes: >>>   Add a qmp command that provides information about currently attached   backend network devices and their configuration. >>

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-08 Thread Alexey Kirillov
08.09.2020, 17:29, "Markus Armbruster" : > Alexey Kirillov writes: > >>  Add a qmp command that provides information about currently attached >>  backend network devices and their configuration. >> >>  Signed-off-by: Alexey Kirillov > > One more: name it query-netdev for consistency with query-ch

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-08 Thread Markus Armbruster
Eric Blake writes: > On 9/7/20 7:39 AM, Markus Armbruster wrote: > This is union Netdev plus a common member @peer-id, less the variant members for NetClientDriver values 'nic' and 'hubport'. Can 'type: 'nic' and 'type': 'hubport' occur? >>> >>> No, it can't. We don't sup

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-08 Thread Markus Armbruster
Alexey Kirillov writes: > Add a qmp command that provides information about currently attached > backend network devices and their configuration. > > Signed-off-by: Alexey Kirillov One more: name it query-netdev for consistency with query-chardev and query-memdev.

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-08 Thread Eric Blake
On 9/7/20 7:39 AM, Markus Armbruster wrote: This is union Netdev plus a common member @peer-id, less the variant members for NetClientDriver values 'nic' and 'hubport'. Can 'type: 'nic' and 'type': 'hubport' occur? No, it can't. We don't support NIC/hubport in query-netdevs, so we neither c

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-07 Thread Markus Armbruster
Alexey Kirillov writes: > Hi! > > 02.09.2020, 14:23, "Markus Armbruster" : >> Alexey Kirillov writes: >> >>>  Add a qmp command that provides information about currently attached >>>  backend network devices and their configuration. >>> >>>  Signed-off-by: Alexey Kirillov >> >> [...] >>>  diff

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-07 Thread Alexey Kirillov
Hi! 02.09.2020, 14:23, "Markus Armbruster" : > Alexey Kirillov writes: > >>  Add a qmp command that provides information about currently attached >>  backend network devices and their configuration. >> >>  Signed-off-by: Alexey Kirillov > > [...] >>  diff --git a/qapi/net.json b/qapi/net.json >>

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-02 Thread Markus Armbruster
Alexey Kirillov writes: > Add a qmp command that provides information about currently attached > backend network devices and their configuration. > > Signed-off-by: Alexey Kirillov [...] > diff --git a/qapi/net.json b/qapi/net.json > index ddb113e5e5..c09322bb42 100644 > --- a/qapi/net.json > ++

[PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-01 Thread Alexey Kirillov
Add a qmp command that provides information about currently attached backend network devices and their configuration. Signed-off-by: Alexey Kirillov --- include/net/net.h | 1 + net/l2tpv3.c | 19 +++ net/net.c | 32 net/netmap.c | 13 + net/slirp.c