Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-25 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 25 Apr 2023 at 13:10, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > -# Notes: @singlestep is enabled through the GDB stub >> > +# Notes: @singlestep is enabled on the command line with >> > +#'-accel tcg,one-insn-per-tb=on', or with the HMP

Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-25 Thread Peter Maydell
On Tue, 25 Apr 2023 at 13:10, Markus Armbruster wrote: > > Peter Maydell writes: > > > -# Notes: @singlestep is enabled through the GDB stub > > +# Notes: @singlestep is enabled on the command line with > > +#'-accel tcg,one-insn-per-tb=on', or with the HMP > > +#'one-insn-per-tb'

Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-24 Thread Peter Maydell
Markus -- could I trouble you for a quick review of this patch? It's the only one in the series that touches QMP. Everything else has been reviewed so otherwise this series is ready to go in. thanks -- PMM On Mon, 17 Apr 2023 at 17:40, Peter Maydell wrote: > > The 'singlestep' member of StatusIn

Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-20 Thread Philippe Mathieu-Daudé
On 17/4/23 18:40, Peter Maydell wrote: The 'singlestep' member of StatusInfo has never done what the QMP documentation claims it does. What it actually reports is whether TCG is working in "one guest instruction per translation block" mode. We no longer need this field for the HMP 'info status'

Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-18 Thread Richard Henderson
On 4/17/23 18:40, Peter Maydell wrote: The 'singlestep' member of StatusInfo has never done what the QMP documentation claims it does. What it actually reports is whether TCG is working in "one guest instruction per translation block" mode. We no longer need this field for the HMP 'info status'

[PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-17 Thread Peter Maydell
The 'singlestep' member of StatusInfo has never done what the QMP documentation claims it does. What it actually reports is whether TCG is working in "one guest instruction per translation block" mode. We no longer need this field for the HMP 'info status' command, as we've moved that information