Re: [PATCH v3 11/16] iotests/297: return error code from run_linters()

2021-10-04 Thread John Snow
On Mon, Oct 4, 2021 at 3:45 AM Hanna Reitz wrote: > On 22.09.21 22:18, John Snow wrote: > > > > > > On Fri, Sep 17, 2021 at 7:00 AM Hanna Reitz > > wrote: > > [...] > > > > > As you say, run_linters() to me seems very iotests-specific still: It > > emits a speci

Re: [PATCH v3 11/16] iotests/297: return error code from run_linters()

2021-10-04 Thread Hanna Reitz
On 22.09.21 22:18, John Snow wrote: On Fri, Sep 17, 2021 at 7:00 AM Hanna Reitz > wrote: [...] As you say, run_linters() to me seems very iotests-specific still: It emits a specific output that is compared against a reference output. Fine for 297, but

Re: [PATCH v3 11/16] iotests/297: return error code from run_linters()

2021-09-22 Thread John Snow
On Fri, Sep 17, 2021 at 7:00 AM Hanna Reitz wrote: > On 16.09.21 06:09, John Snow wrote: > > This turns run_linters() into a bit of a hybrid test; returning non-zero > > on failed execution while also printing diffable information. This is > > done for the benefit of the avocado simple test runne

Re: [PATCH v3 11/16] iotests/297: return error code from run_linters()

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: This turns run_linters() into a bit of a hybrid test; returning non-zero on failed execution while also printing diffable information. This is done for the benefit of the avocado simple test runner, which will soon be attempting to execute this test from a diff

[PATCH v3 11/16] iotests/297: return error code from run_linters()

2021-09-15 Thread John Snow
This turns run_linters() into a bit of a hybrid test; returning non-zero on failed execution while also printing diffable information. This is done for the benefit of the avocado simple test runner, which will soon be attempting to execute this test from a different environment. (Note: universal_n