Re: [PATCH v3 11/22] qga: conditionalize schema for commands requiring linux/win32

2024-07-19 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Jul 12, 2024 at 4:25 PM Daniel P. Berrangé wrote: > Some commands were blocked based on CONFIG_FSFREEZE, but their > impl had nothing todo with CONFIG_FSFREEZE, and were instead > either Linux-only, or Win+Linux-only. > > Rather than creating stubs for ev

[PATCH v3 11/22] qga: conditionalize schema for commands requiring linux/win32

2024-07-12 Thread Daniel P . Berrangé
Some commands were blocked based on CONFIG_FSFREEZE, but their impl had nothing todo with CONFIG_FSFREEZE, and were instead either Linux-only, or Win+Linux-only. Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to fully exclude