Re: [PATCH v3 12/28] accel/tcg: Merge tcg_exec_init into tcg_init_machine

2021-06-10 Thread Richard Henderson
On 6/9/21 7:58 AM, Luis Fernando Fujita Pires wrote: From: Richard Henderson There is only one caller, and shortly we will need access to the MachineState, which tcg_init_machine already has. Signed-off-by: Richard Henderson --- accel/tcg/internal.h | 2 ++ include/sysemu/tcg.h

RE: [PATCH v3 12/28] accel/tcg: Merge tcg_exec_init into tcg_init_machine

2021-06-09 Thread Luis Fernando Fujita Pires
From: Richard Henderson > There is only one caller, and shortly we will need access to the MachineState, > which tcg_init_machine already has. > > Signed-off-by: Richard Henderson > --- > accel/tcg/internal.h | 2 ++ > include/sysemu/tcg.h | 2 -- > accel/tcg/tcg-all.c | 14 ++

Re: [PATCH v3 12/28] accel/tcg: Merge tcg_exec_init into tcg_init_machine

2021-06-08 Thread Richard Henderson
On 6/8/21 4:55 AM, Alex Bennée wrote: +tcg_init(s->tb_size * 1024 * 1024, s->splitwx_enabled); + nit: you could clean up to use unit.h definitions, i.e. tb->size * MiB Otherwise: Reviewed-by: Alex Bennée Amusingly, I cleaned that up this week while rebasing. r~

Re: [PATCH v3 12/28] accel/tcg: Merge tcg_exec_init into tcg_init_machine

2021-06-08 Thread Alex Bennée
Richard Henderson writes: > There is only one caller, and shortly we will need access > to the MachineState, which tcg_init_machine already has. > > Signed-off-by: Richard Henderson > --- > accel/tcg/internal.h | 2 ++ > include/sysemu/tcg.h | 2 -- > accel/tcg/tcg-all.c | 1

[PATCH v3 12/28] accel/tcg: Merge tcg_exec_init into tcg_init_machine

2021-05-02 Thread Richard Henderson
There is only one caller, and shortly we will need access to the MachineState, which tcg_init_machine already has. Signed-off-by: Richard Henderson --- accel/tcg/internal.h | 2 ++ include/sysemu/tcg.h | 2 -- accel/tcg/tcg-all.c | 14 +- accel/tcg/translate-all.c |