Re: [PATCH v3 13/15] qapi: add HOTPLUG_STATE event

2023-02-10 Thread Vladimir Sementsov-Ogievskiy
On 10.02.23 15:01, Markus Armbruster wrote: What do @hotplug-device and @device name? Are these qdev-id? What kind of paths are @hotplug-path and @path? Are these paths to an object device in the QOM tree? Which object? device / path is same name and path as for DEVICE_DELETED Got it. But

Re: [PATCH v3 13/15] qapi: add HOTPLUG_STATE event

2023-02-10 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 10.02.23 13:23, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> For PCIe and SHPC hotplug it's important to track led indicators, >>> especially the power led. Add an event that helps. >>> >>> Signed-off-by: Vladimir Sementsov-Og

Re: [PATCH v3 13/15] qapi: add HOTPLUG_STATE event

2023-02-10 Thread Vladimir Sementsov-Ogievskiy
On 10.02.23 13:23, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: For PCIe and SHPC hotplug it's important to track led indicators, especially the power led. Add an event that helps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/qdev.json | 62 ++

Re: [PATCH v3 13/15] qapi: add HOTPLUG_STATE event

2023-02-10 Thread Philippe Mathieu-Daudé
On 10/2/23 11:47, Vladimir Sementsov-Ogievskiy wrote: On 10.02.23 00:28, Philippe Mathieu-Daudé wrote: On 9/2/23 21:08, Vladimir Sementsov-Ogievskiy wrote: For PCIe and SHPC hotplug it's important to track led indicators, especially the power led. Add an event that helps. Signed-off-by: Vladim

Re: [PATCH v3 13/15] qapi: add HOTPLUG_STATE event

2023-02-10 Thread Vladimir Sementsov-Ogievskiy
On 10.02.23 00:28, Philippe Mathieu-Daudé wrote: On 9/2/23 21:08, Vladimir Sementsov-Ogievskiy wrote: For PCIe and SHPC hotplug it's important to track led indicators, especially the power led. Add an event that helps. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   qapi/qdev.json   | 62

Re: [PATCH v3 13/15] qapi: add HOTPLUG_STATE event

2023-02-10 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > For PCIe and SHPC hotplug it's important to track led indicators, > especially the power led. Add an event that helps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/qdev.json | 62 > include

Re: [PATCH v3 13/15] qapi: add HOTPLUG_STATE event

2023-02-09 Thread Philippe Mathieu-Daudé
On 9/2/23 21:08, Vladimir Sementsov-Ogievskiy wrote: For PCIe and SHPC hotplug it's important to track led indicators, especially the power led. Add an event that helps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/qdev.json | 62 in

[PATCH v3 13/15] qapi: add HOTPLUG_STATE event

2023-02-09 Thread Vladimir Sementsov-Ogievskiy
For PCIe and SHPC hotplug it's important to track led indicators, especially the power led. Add an event that helps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/qdev.json | 62 include/hw/pci/pci.h | 15 +++ hw/pci/pci.c