Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions

2022-03-04 Thread Eugenio Perez Martin
On Fri, Mar 4, 2022 at 7:30 AM Markus Armbruster wrote: > > Eugenio Perez Martin writes: > > > Yes, that's right. I expressed my point poorly actually, I'll go the > > reverse. > > > > qapi-gen.py forces me to write a comment in the doc: > > qapi/block-core.json:2971: feature 'unstable' lacks do

Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions

2022-03-03 Thread Markus Armbruster
Eugenio Perez Martin writes: > Yes, that's right. I expressed my point poorly actually, I'll go the reverse. > > qapi-gen.py forces me to write a comment in the doc: > qapi/block-core.json:2971: feature 'unstable' lacks documentation > > When I add the documentation line, it's enough to add @unst

Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions

2022-03-03 Thread Eugenio Perez Martin
On Thu, Mar 3, 2022 at 1:00 PM Markus Armbruster wrote: > > Eugenio Perez Martin writes: > > > On Thu, Mar 3, 2022 at 7:09 AM Markus Armbruster wrote: > >> > >> Eugenio Pérez writes: > >> > >> > Finally offering the possibility to enable SVQ from the command line. > >> > > >> > Signed-off-by: E

Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions

2022-03-03 Thread Markus Armbruster
Eugenio Perez Martin writes: > On Thu, Mar 3, 2022 at 7:09 AM Markus Armbruster wrote: >> >> Eugenio Pérez writes: >> >> > Finally offering the possibility to enable SVQ from the command line. >> > >> > Signed-off-by: Eugenio Pérez >> > --- >> > qapi/net.json| 5 - >> > net/vhost-vdp

Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions

2022-03-03 Thread Eugenio Perez Martin
On Thu, Mar 3, 2022 at 7:09 AM Markus Armbruster wrote: > > Eugenio Pérez writes: > > > Finally offering the possibility to enable SVQ from the command line. > > > > Signed-off-by: Eugenio Pérez > > --- > > qapi/net.json| 5 - > > net/vhost-vdpa.c | 48 +

Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions

2022-03-02 Thread Markus Armbruster
Eugenio Pérez writes: > Finally offering the possibility to enable SVQ from the command line. > > Signed-off-by: Eugenio Pérez > --- > qapi/net.json| 5 - > net/vhost-vdpa.c | 48 > 2 files changed, 44 insertions(+), 9 deletions(-) > > d

[PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions

2022-03-02 Thread Eugenio Pérez
Finally offering the possibility to enable SVQ from the command line. Signed-off-by: Eugenio Pérez --- qapi/net.json| 5 - net/vhost-vdpa.c | 48 2 files changed, 44 insertions(+), 9 deletions(-) diff --git a/qapi/net.json b/qapi/net.jso