Re: [PATCH v3 14/16] win32: avoid mixing SOCKET and file descriptor space

2023-03-06 Thread Stefan Berger
On 2/21/23 07:47, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Until now, a win32 SOCKET handle is often cast to an int file descriptor, as this is what other OS use for sockets. When necessary, QEMU eventually queries whether it's a socket with the help of fd_is_socket(). Howe

Re: [PATCH v3 14/16] win32: avoid mixing SOCKET and file descriptor space

2023-03-05 Thread Marc-André Lureau
Hi On Fri, Mar 3, 2023 at 12:54 AM Stefan Berger wrote: > > > > On 2/21/23 07:47, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Until now, a win32 SOCKET handle is often cast to an int file > > descriptor, as this is what other OS use for sockets. When necessary, > > QEM

Re: [PATCH v3 14/16] win32: avoid mixing SOCKET and file descriptor space

2023-03-02 Thread Stefan Berger
On 2/21/23 07:47, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Until now, a win32 SOCKET handle is often cast to an int file descriptor, as this is what other OS use for sockets. When necessary, QEMU eventually queries whether it's a socket with the help of fd_is_socket(). Howe

[PATCH v3 14/16] win32: avoid mixing SOCKET and file descriptor space

2023-02-21 Thread marcandre . lureau
From: Marc-André Lureau Until now, a win32 SOCKET handle is often cast to an int file descriptor, as this is what other OS use for sockets. When necessary, QEMU eventually queries whether it's a socket with the help of fd_is_socket(). However, there is no guarantee of conflict between the fd and