Re: [PATCH v3 14/33] serial-mm: add "regshift" property

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 07:54, Marc-André Lureau wrote: > > Hi > > On Mon, Nov 18, 2019 at 6:54 PM Peter Maydell > wrote: > > > > On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau > > wrote: > > > +static Property serial_mm_properties[] = { > > > +DEFINE_PROP_UINT8("regshift", SerialMM,

Re: [PATCH v3 14/33] serial-mm: add "regshift" property

2019-11-19 Thread Marc-André Lureau
Hi On Mon, Nov 18, 2019 at 6:54 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau > wrote: > > > > And a property and rename "it_shift" field to "regshift", as it seems > > to be more popular (and I don't know what "it" stands for). > > > > Signed-off-by: Marc-André

Re: [PATCH v3 14/33] serial-mm: add "regshift" property

2019-11-18 Thread Peter Maydell
On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau wrote: > > And a property and rename "it_shift" field to "regshift", as it seems > to be more popular (and I don't know what "it" stands for). > > Signed-off-by: Marc-André Lureau I have no idea what it_shift means either (I had a look in the git

[PATCH v3 14/33] serial-mm: add "regshift" property

2019-10-23 Thread Marc-André Lureau
And a property and rename "it_shift" field to "regshift", as it seems to be more popular (and I don't know what "it" stands for). Signed-off-by: Marc-André Lureau --- hw/char/serial.c | 23 ++- include/hw/char/serial.h | 4 ++-- 2 files changed, 20 insertions(+), 7